feat: bookmark CSVs #608
Merged
feat: bookmark CSVs #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the option to bookmark the current CSV content and to load previously bookmarked files. Bookmarks are stored by chainId and the user can give a name to each of the transfers. Bookmarks also get persisted into local storage such that they are persisted between page loads.
bh2smith
approved these changes
Jul 8, 2024
There was a problem hiding this comment.
All is good here except that I can not run it locally. The "waiting for safe app" appears when not inside safe.
Tried on Firefox [it recognizes it as an app but nothing is ever displayed]
On Brave it says its not an app:
There are a bunch of warnings: Failed to parse source map from which are all rooted in safe-global/safe-apps-sdk/node_modules/@safe-global/safe-gateway-typescript-sdk.
| import { useAppSelector } from "src/stores/store"; | ||
|
|
||
| const HIDE_TIME = 7_000; | ||
|
|
||
| const higherSeverity = (a: Message["severity"], b: Message["severity"]) => { |
|
Tried it! Working well! Merge it baby! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this feature is about
Adds the option to bookmark the current CSV content and to load previously bookmarked files.
Bookmarks are stored by chainId and the user can give a name to each of the transfers.
Bookmarks also get persisted into local storage such that they are persisted between page loads.
Screenshots