Skip to content

Commit

Permalink
chore: github Action 브런치 제약구문 제거 및 코드 간소화 (depromeet#685)
Browse files Browse the repository at this point in the history
* fix: github Action 브런치 제약구문 제거 및 코드 간소화
- branches event trigger branch 네이밍 release로 수정
- type event trigger 추가 및 closed 정의

* fix: fastlane upload prd testflight action 제약 구문 수정
- fastlane upload stg testflight action 코드 리펙토링
- branches event trigger  release 추가
- types  event trigger 제거
  • Loading branch information
Do-hyun-Kim authored Oct 18, 2024
1 parent 9ad25a1 commit 5fb21d5
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/swift.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@ name: Bibbi
on:
push:
branches:
- feat/*
- fix/*
- release
pull_request:
branches:
- release/**
- release
- develop

jobs:
Expand Down Expand Up @@ -61,7 +60,7 @@ jobs:
run: tuist generate

- name: fastlane upload_prd_testflight
if: github.event.pull_request.base.ref == 'release' && github.head_ref == 'develop'
if: ${{ github.ref == 'refs/heads/release' && github.event_name == 'push' }}
env:
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
Expand All @@ -82,7 +81,7 @@ jobs:


- name: fastlane upload_stg_testflight
if: github.event.pull_request.base.ref == 'develop' && startsWith(github.head_ref, 'feat/')
if: ${{ github.event.pull_request.merged == true && github.event.pull_request.base.ref == 'develop' }}
env:
APP_STORE_CONNECT_API_KEY_KEY_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_KEY_ID }}
APP_STORE_CONNECT_API_KEY_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_API_KEY_ISSUER_ID }}
Expand Down

0 comments on commit 5fb21d5

Please sign in to comment.