Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large code base with hundreds of tests - summary missing #30

Closed
shawner18 opened this issue Oct 3, 2023 · 4 comments · Fixed by #32 or #45
Closed

Large code base with hundreds of tests - summary missing #30

shawner18 opened this issue Oct 3, 2023 · 4 comments · Fixed by #32 or #45

Comments

@shawner18
Copy link
Contributor

We have a large project that exceeds the markdown post for the test summary information. The information below is reported. It would be nice if this could be split or perhaps posted to a file, that could be added to the pr.

$GITHUB_STEP_SUMMARY upload aborted, supports content up to a size of 1024k, got 54351k. For more information see: https://docs.github.com/actions/using-workflows/workflow-commands-for-github-actions#adding-a-markdown-summary

@shawner18
Copy link
Contributor Author

shawner18 commented Oct 3, 2023

Adding more context, it appears the error might have been due to the output/debug trace of some of the tests.
After pairing that down, I do see details in the in the summary link, however not all tests are listed (assume due to truncation). Also if a failure occurs, it is still effected by the truncation.

Couple of ideas

  • Config option for disabling the output column for successes
  • Allow option for only showing failures on summary screen, when there are many tests

@bibipkins
Copy link
Owner

Hi @shawner18! thanks for checking out this action!
Thank you for the provided suggestions and the PR! I think both ideas make sense. I will review it as soon as I have some time.
A couple of quick temporary solutions that might help in the meantime:

  • you can use --verbosity=minimal with your dotnet test command to reduce the amount of output
  • in case you are using Entity Framework - disable EF logging during the test run, it can grow huge
  • split tests into multiple runs (could be based on project/test-type/team) and have the action run separately for each

@bibipkins bibipkins linked a pull request Oct 4, 2023 that will close this issue
@shawner18
Copy link
Contributor Author

shawner18 commented Oct 4, 2023

@bibipkins thank you for the feedback. What you mentioned below are the steps I took between my first post and comment. That significantly paired down the output and avoided the error message and was just seeing the truncation of the output.
Thank you for all your hard work on this, it is a really nice action.

  • you can use --verbosity=minimal with your dotnet test command to reduce the amount of output
  • in case you are using Entity Framework - disable EF logging during the test run, it can grow huge

Also opened a new PR, as I discovered how you were testing late in my changes, so I added some tests as well.
#32

@bibipkins bibipkins linked a pull request Oct 5, 2023 that will close this issue
@bibipkins
Copy link
Owner

@shawner18 Dont mind the errors the action produces right now. Github Actions have issues with using github token when PR is opened using a forked repository actions/first-interaction#10
The PR looks good, I reviewed it and added just a few minor comments. Once we resolve them we can merge and see how it runs on the repo. If everything goes well I will create a new release

@bibipkins bibipkins reopened this Oct 19, 2023
@bibipkins bibipkins linked a pull request Feb 7, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants