Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move spherical harmonic basis keyvalue? #76

Closed
Lestropie opened this issue Oct 7, 2022 · 1 comment
Closed

Move spherical harmonic basis keyvalue? #76

Lestropie opened this issue Oct 7, 2022 · 1 comment

Comments

@Lestropie
Copy link
Collaborator

Currently the spherical harmonic basis used is specified in the model JSON file, rather than the ODF JSON file. With inheritance this makes sense only if all of the model derivatives are SH ODFs. Likely a better solution would be for the individual ODFs to have within their sidecar files the SH convention used. That would prevent that information from being inherited by files to which it is not applicable, and would mean that any ODF image - metadata pair can be reasonably interpreted without necessitating reference back to the model JSON.

@Lestropie
Copy link
Collaborator Author

Intrinsically addressed by #92, as there is no model-wise JSON file, and "OrientationEncoding" is defined individually for each data file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant