Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.7.2: Uninformative failure when running on non-fetched git-annexed files #1288

Open
yarikoptic opened this issue May 19, 2021 · 1 comment
Labels

Comments

@yarikoptic
Copy link
Contributor

ran from a singularity image on a datalad dataset in elderly git annex direct mode:

(datalad) [d31548v@discovery7 data_discovery]$ singularity run -B $PWD /XXX/bidsvalidator-1.7.2.sif $PWD
[email protected]

Unhandled rejection (
  reason: TypeError: Cannot read property 'length' of undefined
    at fileArrayToObject (/src/utils/files/readDir.js:39:33)
    at Object.readDir (/src/utils/files/readDir.js:27:17)

might be because some files are still not fetched annexed files. But it shouldn't crash like this - should tell what directory at least it has an issue with

@sappelhoff
Copy link
Member

I got the same issue with the docker image after datalad cloneing a dataset and running bids-validator without datalad getting all files first.

I agree that an error message instead of a crash would be nice - but I wouldn't know where to start to make a PR for this.

@sappelhoff sappelhoff changed the title 1.7.2: Cannot read property 'length' of undefined 1.7.2: Uninformative failure when running on non-fetched git-annexed files Sep 13, 2021
@effigies effigies added the legacy label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants