Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY] Move from xml to defusedxml for XML parsing #119

Closed
fabianegli opened this issue Apr 6, 2022 · 1 comment · Fixed by #148
Closed

[SECURITY] Move from xml to defusedxml for XML parsing #119

fabianegli opened this issue Apr 6, 2022 · 1 comment · Fixed by #148

Comments

@fabianegli
Copy link
Collaborator

XML is not save to parse in its original specification. See the official official Python builtin xml documentation which promotes the use of the defusedxml package. Pyre in the CI of this repo is complaining about it, too.

The reason why this is important is because we can not know whether or not the XML files a user parses is benign or not. We should protect our users from known security vulnerabilities.

@ypriverol
Copy link
Member

#148 this will be tackling the issue.

@ypriverol ypriverol linked a pull request Sep 4, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants