Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: eslint config is incorrect #106

Open
g-elwell opened this issue Mar 20, 2024 · 3 comments · Fixed by #104
Open

[Bug]: eslint config is incorrect #106

g-elwell opened this issue Mar 20, 2024 · 3 comments · Fixed by #104
Assignees
Labels
bug Something isn't working

Comments

@g-elwell
Copy link
Member

What happened?

I am receiving errors for several eslint rules which should be disabled according to the provided config, and no warning for rules which should be enabled. I haven't compiled an exhaustive list as it seems most likely that some issue with the config formatting is causing it to be ignored and/or overwritten with imported rulesets we are extending from.

This seems to have been introduced since 1.2.5. Here is the CLI output from the same code on 1.3.0 and 1.2.5 for comparison:

1.3.0

Screenshot 2024-03-20 at 09 36 06

1.2.5

image

Which environments are you experiencing the issue on?

CLI (macOS, Windows, etc)

Relevant log output

No response

@g-elwell g-elwell added the bug Something isn't working label Mar 20, 2024
@ampersarnie
Copy link
Member

@g-elwell There's a fix for this already in main just not released right now. I'll get 1.3.1 released shortly to address this. See: #104

@ampersarnie ampersarnie linked a pull request Mar 21, 2024 that will close this issue
@ampersarnie
Copy link
Member

@g-elwell This should be resolved in 1.3.1, check that out.

If there's still issues around this feel free to reopen this issue and let me know.

@g-elwell
Copy link
Member Author

g-elwell commented Apr 2, 2024

@ampersarnie unfortunately it appears as though 1.3.1 contains a regression related to eslint import aliases. I'm attempting to import from src/components using @Components which is working in 1.2.5. I'll investigate further but reopening this issue in the mean time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants