-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Iframe property in embedded checkout to allow apple pay #2189
Comments
@bc-peng - Here is the release notes of Safari 17 by apple. You can find Release Notes Link: https://developer.apple.com/documentation/safari-release-notes/safari-17-release-notes#Apple-Pay |
Thanks for informing us @hardikbhut333. We will look at this and see if we can implement this. |
@animesh1987 - I have already raised PR for this fix. You can look into this. #2190 |
Nice 👍 let's discuss on the PR. |
Is your feature request related to a problem? Please describe.
Apple Safari has given 17 release and now it supports apple pay. But in embedded checkout we need to pass
allow="payment"
as attribute in iframe. Right now the attribute isiframe.allowPaymentRequest = true
.allowPaymentRequest
attribute is deprecated and now It'sallow="payment"
Describe the solution you'd like
Solution is instead of using
iframe.allowPaymentRequest = true
useallow="payment"
in following filecheckout-sdk-js/packages/core/src/embedded-checkout/resizable-iframe-creator.ts
(line no. 27)Additional context
Once the above change will be done, it will start loading apple pay using embedded checkout on Safari browser. Look at the attached screenshot.
The text was updated successfully, but these errors were encountered: