Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bdv.utils.VolatileSource conflicts with playground #62

Closed
mkitti opened this issue Feb 6, 2024 · 7 comments
Closed

bdv.utils.VolatileSource conflicts with playground #62

mkitti opened this issue Feb 6, 2024 · 7 comments

Comments

@mkitti
Copy link

mkitti commented Feb 6, 2024

There is another bdv.utils.VolatileSource in bigdataviewer-playground:

https://github.com/bigdataviewer/bigdataviewer-playground/blob/05c48eef7fa724e32bc595ea8949c206cdbe2333/src%2Fmain%2Fjava%2Fbdv%2Futil%2FVolatileSource.java#L88

@tpietzsch
Copy link
Member

Argh. We should really adopt naming packages after artefacts. bdv.util should be org.bigdataviewer.vistools for bigdataviewer-vistools. And org.bigdataviewer.playground for bigdataviewer-playground.

@tpietzsch
Copy link
Member

@axtimwalde @NicoKiaru Can you estimate how widely used your respective versions of VolatileSource are? Can we still just rename one of them?

@NicoKiaru
Copy link
Contributor

NicoKiaru commented Feb 7, 2024

I've renamed the one in bigdataviewer-playground, it's used only internally and is not in any of the persisted json files around.

If I find some time, I'll do it this week, but most probably next week.

I want to fix the compability with BigWarp at the same time.

@NicoKiaru
Copy link
Contributor

But I need to have a parent pom scijava with a stable version to make my builds!

It's not the case now:
scijava/pom-scijava#254

I just test with a temp snapshot parent pom from @bogovicj 's branch, but I can't release because of that

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/updated-ngff-support-in-fiji-hdf5-n5-zarr-ome-ngff/91705/43

@imagesc-bot
Copy link

This issue has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/updated-ngff-support-in-fiji-hdf5-n5-zarr-ome-ngff/91705/44

@axtimwalde
Copy link
Member

playground will rename its source or re-use the vistools implementation after bugs are fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants