Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPi install issue #726

Closed
Guitaricet opened this issue Feb 10, 2022 · 6 comments
Closed

PyPi install issue #726

Guitaricet opened this issue Feb 10, 2022 · 6 comments

Comments

@Guitaricet
Copy link
Contributor

Executing pip install promptsource causes the following error for me

    ERROR: Command errored out with exit status 1:
     command: /home/vlialin/miniconda3/envs/cqg/bin/python -c 'import io, os, sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-install-higkq2vp/promptsource_d9e0de5b5f404523afa2d8789946c6a8/setup.py'"'"'; __file__='"'"'/tmp/pip-install-higkq2vp/promptsource_d9e0de5b5f404523afa2d8789946c6a8/setup.py'"'"';f = getattr(tokenize, '"'"'open'"'"', open)(__file__) if os.path.exists(__file__) else io.StringIO('"'"'from setuptools import setup; setup()'"'"');code = f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-qnu5er_g
         cwd: /tmp/pip-install-higkq2vp/promptsource_d9e0de5b5f404523afa2d8789946c6a8/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-install-higkq2vp/promptsource_d9e0de5b5f404523afa2d8789946c6a8/setup.py", line 6, in <module>
        with open('requirements.txt') as requirements_file:
    FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'
    ----------------------------------------

I was trying to understand what is a possible problem, but this one is confusing, because the previous line with open("README.md", "r", encoding="utf-8") as readme_file: also reads a local file and it does not fail.

I will make a PR that removes requirements.txt in favor of explicitly providing a list of dependencies to install_requires.

Guitaricet added a commit to Guitaricet/promptsource that referenced this issue Feb 10, 2022
@Guitaricet Guitaricet changed the title PyPy install issue PyPi install issue Feb 10, 2022
@Guitaricet
Copy link
Contributor Author

The PR: #727

@awebson
Copy link
Contributor

awebson commented Feb 14, 2022

Thanks Vlad! @stephenbach would you mind taking a look at this? I'm not sure if it's related but right now I can't even pip install promptsource on an empty Colab.

WARNING: Discarding https://files.pythonhosted.org/packages/b7/e1/4b05573af2c2d3901d0a7e78dd604a8ef756d7a74cdf4573246779f6ed6d/promptsource-0.2.0.tar.gz#sha256=e96effb6e49e5b6f9d817eb259382c3a3db2eb1e950b8d797056a6898205b4b7 (from https://pypi.org/simple/promptsource/) (requires-python:>=3.7, <3.8). Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
ERROR: Could not find a version that satisfies the requirement promptsource (from versions: 0.2.0)
ERROR: No matching distribution found for promptsource

@Guitaricet
Copy link
Contributor Author

@awebson This is due to python=3.7 requirement. If you use pip with any other version of python it cannot find promptsource at all.

Do you know the reason behind such a strict python version requirement? Can we allow python>=3.7?

@awebson
Copy link
Contributor

awebson commented Feb 14, 2022

FWIW, I did !python --version and Colab currently has 3.7.12. Also, running !pip install git+https://github.com/bigscience-workshop/promptsource.git works.

I'm not sure why we require 3.7 aside from the fact that the readme says “for stability reasons”.

@VictorSanh
Copy link
Member

We pinned to Python3.7 (in this commit) for various rendering bugs reasons (see #416, #385, #444).

Removing this constraint (#584) would require addressing #725 at the same time which is a little bit involved because the state management changed! but absolutely feel free to assign yourselves!

VictorSanh added a commit that referenced this issue Feb 14, 2022
* Resolves PyPy install issue #726

* remove requirements in ci workflow

Co-authored-by: VictorSanh <[email protected]>
@VictorSanh
Copy link
Member

I just did a patch release with your fix @Guitaricet

@awebson , also tested this new release on Colab and it seems to work smoothly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants