Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paginate search results? #357

Open
mbriney opened this issue Jan 11, 2019 · 1 comment
Open

Paginate search results? #357

mbriney opened this issue Jan 11, 2019 · 1 comment
Milestone

Comments

@mbriney
Copy link

mbriney commented Jan 11, 2019

Has there been any thoughts to allowing the BigTreeModule search function to be able to paginate more easily? Similarly to how getPageCount and getPage can be leveraged?

@timbuckingham
Copy link
Collaborator

With the current crazy ordering of parameters to that method, I think sticking page at the end would be... non-ideal. On the other hand, giving it the ability to paginate would be very helpful. I think this might need a refactor in BigTree 5 when we break some backwards compatibility -- BigTreeModule will still stick around but it's likely that module classes will by default extend a different class instead.

I'm going to keep this issue open while I work that out and will give you an update to take a look at the new class to get feedback once it's in a decent state!

@timbuckingham timbuckingham added this to the 5.0 milestone Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants