Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved archive cookiecutter templates #98

Merged

Conversation

eudesbarbosa
Copy link
Member

@eudesbarbosa eudesbarbosa commented Jun 14, 2022

addresses #96

Changes

  • Moved archive cookiecutter directory - isolated ISA templates.
  • Moved config files away from template directory.

@eudesbarbosa
Copy link
Member Author

@messersc, do you mind checking if I missed something?
...and also to review when we agree it is done?

@messersc
Copy link
Contributor

Happy to help, but of course Eric please chime in if I misrepresent something as you were the main author I believe.

@eudesbarbosa I think we will need everything from the isa-tpl/archive directory. Regarding where to put it, I think keeping it in its own directory might be better. So something like archive/templates or similar.

If you are happy with the changes, let me know and I will do a test run.

Clemens

@eudesbarbosa eudesbarbosa changed the title Restructured isa_tpl/archive to include only cookiecutter related files Moved archive cookiecutter templates Jun 15, 2022
@eudesbarbosa
Copy link
Member Author

Agreed. Added the suggestion in today's commit.

@eudesbarbosa eudesbarbosa marked this pull request as ready for review June 15, 2022 08:08
@eudesbarbosa eudesbarbosa requested review from ericblanc20 and messersc and removed request for ericblanc20 June 15, 2022 08:08
@eudesbarbosa eudesbarbosa merged commit a70ff72 into bihealth:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants