Skip to content

Commit

Permalink
fix timeline link dict blank key handling (#1462)
Browse files Browse the repository at this point in the history
  • Loading branch information
mikkonie committed Aug 7, 2024
1 parent 47ef9dc commit ba46c14
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 2 deletions.
10 changes: 10 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@ Changelog for the **SODAR Core** Django app package. Loosely follows the
`Keep a Changelog <http://keepachangelog.com/en/1.0.0/>`_ guidelines.


Unreleased
==========

Fixed
-----

- **Timeline**
- Deprecated link dict ``blank`` field assumed as mandatory (#1462)


v1.0.0 (2024-07-19)
===================

Expand Down
2 changes: 1 addition & 1 deletion docs/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
# The short X.Y version
version = '1.0'
# The full version, including alpha/beta/rc tags
release = '1.0.0'
release = '1.0.1-WIP'


# -- General configuration ---------------------------------------------------
Expand Down
9 changes: 9 additions & 0 deletions docs/source/major_changes.rst
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,15 @@ older SODAR Core version. For a complete list of changes in current and previous
releases, see the :ref:`full changelog<changelog>`.


v1.0.1 (WIP)
************

Release Highlights
==================

**TODO**


v1.0.0 (2024-07-19)
*******************

Expand Down
2 changes: 1 addition & 1 deletion timeline/api.py
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def _get_ref_description(cls, event, ref_label, app_plugin, request):
link = PluginObjectLink(
url=link['url'],
name=link['label'],
blank=link['blank'],
blank=link.get('blank', False),
)
if not link.name:
logger.warning(
Expand Down

0 comments on commit ba46c14

Please sign in to comment.