From d91eede2558cb04bb2103b7d35860be4e3a1040c Mon Sep 17 00:00:00 2001
From: Mikko Nieminen <mikko.nieminen@bih-charite.de>
Date: Mon, 2 Sep 2024 18:13:40 +0200
Subject: [PATCH] update remote sync ui app setting rendering (#1473, #1474)

---
 CHANGELOG.rst                                  |  7 +++++++
 docs/source/major_changes.rst                  |  4 +++-
 .../projectroles/remoteproject_sync.html       | 18 +++++++++---------
 3 files changed, 19 insertions(+), 10 deletions(-)

diff --git a/CHANGELOG.rst b/CHANGELOG.rst
index 95aa21c7..96a56cbf 100644
--- a/CHANGELOG.rst
+++ b/CHANGELOG.rst
@@ -8,11 +8,18 @@ Changelog for the **SODAR Core** Django app package. Loosely follows the
 Unreleased
 ==========
 
+Added
+-----
+
+- **Projectroles**
+    - Truncate app setting values in ``remoteproject_sync.html`` (#1474)
+
 Fixed
 -----
 
 - **Projectroles**
     - Incorrect app plugin link order in ``get_project_app_links()`` (#1468)
+    - Empty JSON value rendering in ``remoteproject_sync.html`` (#1473)
 
 
 v1.0.1 (2024-08-08)
diff --git a/docs/source/major_changes.rst b/docs/source/major_changes.rst
index aa01701a..91dace5e 100644
--- a/docs/source/major_changes.rst
+++ b/docs/source/major_changes.rst
@@ -16,7 +16,9 @@ v1.0.2 (WIP)
 Release Highlights
 ==================
 
-TBA
+- Update app setting rendering in remote sync UI
+- Fix project sidebar and dropdown app plugin link order
+- General bug fixes and minor updates
 
 
 v1.0.1 (2024-08-08)
diff --git a/projectroles/templates/projectroles/remoteproject_sync.html b/projectroles/templates/projectroles/remoteproject_sync.html
index 24816f08..c1fcce50 100644
--- a/projectroles/templates/projectroles/remoteproject_sync.html
+++ b/projectroles/templates/projectroles/remoteproject_sync.html
@@ -252,15 +252,15 @@ <h4>
                     <td>
                       {% if a.app_plugin %}{{ a.app_plugin }}{% else %}projectroles{% endif %}
                     </td>
-                    <td>
-                      {% if a.type == 'JSON' %}
-                        {{ a.value_json }}
-                      {% elif a.type == 'BOOLEAN' %}
-                        {% if a.value == '1' %}True{% else %}False{% endif %}
-                      {% else %}
-                        {{ a.value }}
-                      {% endif %}
-                    </td>
+                    {% if a.type == 'JSON' and a.value_json %}
+                      <td class="text-muted font-italic">JSON</td>
+                    {% elif a.type == 'JSON' %}
+                      <td class="text-muted font-italic">Empty</td>
+                    {% elif a.type == 'BOOLEAN' %}
+                      <td class="text-monospace">{% if a.value == '1' %}True{% else %}False{% endif %}</td>
+                    {% else %}
+                      <td class="text-monospace">{{ a.value | truncatechars:255 }}</td>
+                    {% endif %}
                     <td>{{ a.status | title }}</td>
                   </tr>
                 {% endif %}