Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move projectroles base test classes and helpers to base module(s) #1431

Open
mikkonie opened this issue Jun 13, 2024 · 0 comments
Open

Move projectroles base test classes and helpers to base module(s) #1431

mikkonie opened this issue Jun 13, 2024 · 0 comments
Assignees
Labels
app: projectroles Issue in the projectroles app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc.
Milestone

Comments

@mikkonie
Copy link
Collaborator

mikkonie commented Jun 13, 2024

We should consider moving projectroles base test classes and helpers, which are expected to be used in SODAR Core using sites, into base module(s) instead of having them in the same module as SODAR Core specific test cases.

IMHO this would make it easier to manage base classes and helpers, differentiate them from tests and make the test case modules less bloated. As an example, one can look at the projectroles UI tests where the helpers take up quite a bit of the already rather large module.

This is something I have already done in SODAR with taskflowbackend tests and it clarified things a whole lot.

I'll still have to think further about whether this is a good idea or not, this issue is moslty intended as a note-to-self. Comments are welcome of course. This will not be done before at least v1.1, hence the tag.

See also #1253.

@mikkonie mikkonie added breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc. app: projectroles Issue in the projectroles app labels Jun 13, 2024
@mikkonie mikkonie added this to the v1.1.0 milestone Jun 13, 2024
@mikkonie mikkonie self-assigned this Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: projectroles Issue in the projectroles app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc.
Projects
None yet
Development

No branches or pull requests

1 participant