Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify differences between "internal" and "common" Ajax views? #1447

Open
mikkonie opened this issue Jun 27, 2024 · 0 comments
Open

Clarify differences between "internal" and "common" Ajax views? #1447

mikkonie opened this issue Jun 27, 2024 · 0 comments
Labels
app: projectroles Issue in the projectroles app internal Changes invisible to the user or APIs (e.g. refactoring and optimization) tbd Comments wanted, spec/schedule/prioritization to be decided, etc.

Comments

@mikkonie
Copy link
Collaborator

As of v1.0, the projectroles app features two "common" Ajax views intended to be used by SODAR Core based sites if needed. These are SidebarContentAjaxView and UserDropdownContentAjaxView. Other Ajax views, however, are intended to only be used by existing projectroles views.

We probably should make this difference more clear by e.g. separating the "common" views into a separate module, or at least a clearly separated section within the existing module. This is also to remind us developers that making changes to these views may cause issues.

Also, one option would be to simply change these into "real" REST API views and have them follow a relevant versioning scheme.

Not major or urgent IMHO, but opening the ticket so this can be thought about.

@mikkonie mikkonie added internal Changes invisible to the user or APIs (e.g. refactoring and optimization) tbd Comments wanted, spec/schedule/prioritization to be decided, etc. app: projectroles Issue in the projectroles app labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: projectroles Issue in the projectroles app internal Changes invisible to the user or APIs (e.g. refactoring and optimization) tbd Comments wanted, spec/schedule/prioritization to be decided, etc.
Projects
None yet
Development

No branches or pull requests

1 participant