Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow blank value for SODARUserAdditionalEmail.secret #1477

Open
mikkonie opened this issue Sep 3, 2024 · 0 comments
Open

Allow blank value for SODARUserAdditionalEmail.secret #1477

mikkonie opened this issue Sep 3, 2024 · 0 comments
Assignees
Labels
app: projectroles Issue in the projectroles app feature Requested feature or enhancement
Milestone

Comments

@mikkonie
Copy link
Collaborator

mikkonie commented Sep 3, 2024

Currently we enforce this as non-unique and non-null. However, when syncing verified alt emails for target sites, the value is useless as the verification has already been performed. Hence, it makes no sense to sync the secret.

However, we must have a value, so as a workaround (see #1476) we create a dummy secret on a target site.

The model should be changed in a way that empty secrets are allowed. This requires a migration, so I'll do it in v1.1 to avoid messing up the squashed migrations.

@mikkonie mikkonie added feature Requested feature or enhancement app: projectroles Issue in the projectroles app labels Sep 3, 2024
@mikkonie mikkonie added this to the v1.1.0 milestone Sep 3, 2024
@mikkonie mikkonie self-assigned this Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: projectroles Issue in the projectroles app feature Requested feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant