Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include local users in UserListAPIView return data? #1507

Open
mikkonie opened this issue Oct 21, 2024 · 0 comments
Open

Include local users in UserListAPIView return data? #1507

mikkonie opened this issue Oct 21, 2024 · 0 comments
Labels
app: projectroles Issue in the projectroles app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc.

Comments

@mikkonie
Copy link
Collaborator

Currently, the user list REST API view omits users in SYSTEM_USER_GROUP unless requested by a superuser.

This kind of makes sense if not allowing local users, as in this case the group only contains e.g. script users which should not be interesting to most users.

However, local users also get added to the group. This means that on a server using local users instead of external auth, regular users might end up seeing an empty user list. That is not intentional.

TBD: The proper way to handle this? Options include, in the ascending order of effort required:

  1. Simply omit the limitation and display all users regardless of the requester
  2. Show system users if PROJECTROLES_ALLOW_LOCAL_USERS==True
  3. Differentiate local human users and script users by different groups, only hide script users

Right now I'm thinking of going with option 1, but I'll think about it. This will require bumping up the projectroles API version to v2.0 and introducing backwards compatibility, of course.

Comments are welcome.

@mikkonie mikkonie added breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc. app: projectroles Issue in the projectroles app labels Oct 21, 2024
@mikkonie mikkonie changed the title Include local usres in UserListAPIView return data? Include local users in UserListAPIView return data? Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: projectroles Issue in the projectroles app breaking Breaking change, to be implemented and documented with care feature Requested feature or enhancement tbd Comments wanted, spec/schedule/prioritization to be decided, etc.
Projects
None yet
Development

No branches or pull requests

1 participant