You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Refactoring the entire backend and its usages to always call sessions as a context manager, or otherwise envoke cleanup() before exiting, is a huge task. Also, this will require us opening and closing a lot more connections than we do now, which may affect performance. The latter is hard to measure before implementing and deploying this improvement.
I don't really see a better way to handle this, so will probably just have to bite the bullet and get it done with.
Tasks
Update session initialization to allow for context manager
Update usage
Optimize the amount of connections opened where applicable
Update tests
Update docs as needed
The text was updated successfully, but these errors were encountered:
mikkonie
changed the title
Refactor irodsbackend methods requiring a connection
Refactor irodsbackend connection handling
Nov 25, 2022
mikkonie
added
feature
Requested feature or enhancement
and removed
internal
Changes invisible to the user or APIs (e.g. refactoring and optimization)
tbd
Comments wanted, spec/schedule/prioritization to be decided, etc.
labels
Nov 25, 2022
mikkonie
added
tbd
Comments wanted, spec/schedule/prioritization to be decided, etc.
and removed
tbd
Comments wanted, spec/schedule/prioritization to be decided, etc.
labels
Nov 25, 2022
We have two problems with the current way of handling disconnections in iRODS.
conn=False
to avoid opening unnecessary connectionscleanup()
command in python-irodsclient does not work as expectedcleanup()
has to be manually called, otherwise iRODS connections are left hangingIrodsAPI.__del__()
, this fails for some reasonRefactoring the entire backend and its usages to always call sessions as a context manager, or otherwise envoke
cleanup()
before exiting, is a huge task. Also, this will require us opening and closing a lot more connections than we do now, which may affect performance. The latter is hard to measure before implementing and deploying this improvement.I don't really see a better way to handle this, so will probably just have to bite the bullet and get it done with.
Tasks
The text was updated successfully, but these errors were encountered: