Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update irodsbackend connection handling #909

Closed
5 tasks done
mikkonie opened this issue Aug 28, 2020 · 1 comment
Closed
5 tasks done

Update irodsbackend connection handling #909

mikkonie opened this issue Aug 28, 2020 · 1 comment
Assignees
Labels
app: irodsbackend Issue in the irodsbackend app feature Requested feature or enhancement
Milestone

Comments

@mikkonie
Copy link
Contributor

mikkonie commented Aug 28, 2020

We have two problems with the current way of handling disconnections in iRODS.

Refactoring the entire backend and its usages to always call sessions as a context manager, or otherwise envoke cleanup() before exiting, is a huge task. Also, this will require us opening and closing a lot more connections than we do now, which may affect performance. The latter is hard to measure before implementing and deploying this improvement.

I don't really see a better way to handle this, so will probably just have to bite the bullet and get it done with.

Tasks

  • Update session initialization to allow for context manager
  • Update usage
  • Optimize the amount of connections opened where applicable
  • Update tests
  • Update docs as needed
@mikkonie mikkonie self-assigned this Jun 15, 2022
@mikkonie mikkonie added the app: irodsbackend Issue in the irodsbackend app label Jun 15, 2022
@mikkonie mikkonie changed the title Irodsbackend: Refactor methods requiring a connection Refactor irodsbackend methods requiring a connection Jun 15, 2022
@mikkonie mikkonie changed the title Refactor irodsbackend methods requiring a connection Refactor irodsbackend connection handling Nov 25, 2022
@mikkonie mikkonie added feature Requested feature or enhancement and removed internal Changes invisible to the user or APIs (e.g. refactoring and optimization) tbd Comments wanted, spec/schedule/prioritization to be decided, etc. labels Nov 25, 2022
@mikkonie mikkonie added this to the v0.13.0 milestone Nov 25, 2022
@mikkonie mikkonie added tbd Comments wanted, spec/schedule/prioritization to be decided, etc. and removed tbd Comments wanted, spec/schedule/prioritization to be decided, etc. labels Nov 25, 2022
@mikkonie mikkonie changed the title Refactor irodsbackend connection handling Update irodsbackend connection handling Nov 29, 2022
@mikkonie
Copy link
Contributor Author

Done. Some niceties I left out to get a fix out for #1542 ASAP, will add separate issues for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: irodsbackend Issue in the irodsbackend app feature Requested feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant