Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter annotations #66

Open
mzur opened this issue May 12, 2020 · 6 comments
Open

Filter annotations #66

mzur opened this issue May 12, 2020 · 6 comments
Assignees
Labels
MI3 Idea for the MI3 project

Comments

@mzur
Copy link
Member

mzur commented May 12, 2020

Largo could be used (by an expert) to review the annotations of a single other user. To do this, the annotations need to be filterable by users. The reviewer/expert can select one (or more) user(s) to see only the annotations of the selected user(s) in Largo.

Summary: Filter by

  • user
  • file
  • date of the image
  • date of the annotation
  • date of the annotation label
  • annotation shape

Ideally, the filters could be combined just like in the volume overview and support less than/equals/more than rules (see biigle/core#359).

@mzur
Copy link
Member Author

mzur commented Jan 26, 2022

This feature should be available for any user, as an editor could use it to review only their own annotations, too.

@mzur mzur moved this to Medium Priority in BIIGLE Roadmap Jan 26, 2022
@mzur mzur removed the discuss label Jan 26, 2022
@mzur mzur changed the title Filter annotations by user Filter annotations by user and file Apr 27, 2022
@mzur
Copy link
Member Author

mzur commented Apr 27, 2022

Large images and videos can have lots of annotations in a single file. Users should be able to review the annotations of a single file, too.

@mzur mzur changed the title Filter annotations by user and file Filter annotations Aug 18, 2022
@mzur mzur added the MI3 Idea for the MI3 project label Oct 18, 2023
@mzur
Copy link
Member Author

mzur commented Oct 24, 2023

The filtering could be implemented in a sidebar tab that is similar to the one of the volume overview. We might need "sorting" and "settings" tabs in the future, too.

@dbrembilla dbrembilla self-assigned this Oct 24, 2024
@dbrembilla
Copy link

While working on this issue, I realized it could be useful to add to the existing API call for image annotations (api/v1/labels/:id/image-annotations) a query part that takes in elements that can be used in the filter (api/v1/labels/:id/image-annotations?shape=1&user=6 etc.). Do you think this is a good idea? To do this I would need to work on the master branch. Otherwise I would need to implement it here, and it does not really make super sense in my head since it would be more of a global behaviour. What do you think @mzur ?

@dbrembilla
Copy link

Vene

While working on this issue, I realized it could be useful to add to the existing API call for image annotations (api/v1/labels/:id/image-annotations) a query part that takes in elements that can be used in the filter (api/v1/labels/:id/image-annotations?shape=1&user=6 etc.). Do you think this is a good idea? To do this I would need to work on the master branch. Otherwise I would need to implement it here, and it does not really make super sense in my head since it would be more of a global behaviour. What do you think @mzur ?

Nevermind, I saw that these parts of the API are already implemented in largo. I will extend the existing ones

@mzur
Copy link
Member Author

mzur commented Oct 31, 2024

Did you have a look at how the filter UI of the volume overview works? I had something similar in mind here because users are already familiar with it. Under the hood the volume overview filter performs one query for each filter rule (i.e. each rule has it's own API endpoint). The results are then combined to the final sequence in the frontend. The alternative would be a single endpoint but with multiple query parameters, as you describe. I don't prefer one of these two as long as the UI is consistent with the volume overview.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MI3 Idea for the MI3 project
Projects
Status: Medium Priority
Development

No branches or pull requests

2 participants