Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Runtime from Pool to Manager (or vice verse) #197

Open
bikeshedder opened this issue Apr 27, 2022 · 0 comments
Open

Pass Runtime from Pool to Manager (or vice verse) #197

bikeshedder opened this issue Apr 27, 2022 · 0 comments
Labels
A-core Area: Core / deadpool A-deadpool-* Area: deadpool backend enhancement New feature or request quality of life Improvements to the API resulting in a better quality of life for the users of deadpool.
Milestone
0.13

Comments

@bikeshedder
Copy link
Owner

As shown in #195 it's quite confusing that both the manager and the pool require a runtime.

For a 1.0 release you should only need to pass the runtime once. Either the pool propagates the runtime to the manager or the manager provides a way for the pool to extract the runtime information from it.

However the solution looks like the end users should not need to pass the runtime information twice into both the manager and the pool structure.
@bikeshedder bikeshedder added enhancement New feature or request A-core Area: Core / deadpool A-deadpool-* Area: deadpool backend labels Apr 27, 2022
@bikeshedder bikeshedder added this to the 1.0.0 milestone Apr 27, 2022
@bikeshedder bikeshedder mentioned this issue Apr 27, 2022
Closed
@bikeshedder bikeshedder added the quality of life Improvements to the API resulting in a better quality of life for the users of deadpool. label Apr 27, 2022
@bikeshedder bikeshedder modified the milestones: 1.0.0, 0.11 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-core Area: Core / deadpool A-deadpool-* Area: deadpool backend enhancement New feature or request quality of life Improvements to the API resulting in a better quality of life for the users of deadpool.
Projects
None yet
Milestone
0.13
Development

No branches or pull requests
1 participant
@bikeshedder