Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL: better documentation for statement caching #362

Open
jaskij opened this issue Nov 3, 2024 · 1 comment
Open

PostgreSQL: better documentation for statement caching #362

jaskij opened this issue Nov 3, 2024 · 1 comment
Labels
A-postgres Area: PostgreSQL support / deadpool-postgres enhancement New feature or request

Comments

@jaskij
Copy link

jaskij commented Nov 3, 2024

As is, the only explanation for how deadpool_postgres handles caching prepared statements I'm aware of is the discussion in #75 . Between that and looking at the source, I understand the behavior and it's fine, but:

  • it's hard to find
  • it's not a contract in the way documentation is, and relying on undocumented behavior and a four year old issue is bad practice

Better documentation - especially the information about ClientWrapper handling the caching internally - would making getting started with deadpool_postgress that much easier.

@bikeshedder
Copy link
Owner

A PR to add this documentation would be highly appreciated! ❤️

@bikeshedder bikeshedder added enhancement New feature or request A-postgres Area: PostgreSQL support / deadpool-postgres labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-postgres Area: PostgreSQL support / deadpool-postgres enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants