Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal redis client #373

Open
ederuiter opened this issue Dec 4, 2024 · 1 comment
Open

Universal redis client #373

ederuiter opened this issue Dec 4, 2024 · 1 comment
Labels
A-redis Area: Redis / deadpool-redis enhancement New feature or request

Comments

@ederuiter
Copy link
Contributor

Currently chirpstack has it own thin wrapper around deadpool-redis (https://github.com/chirpstack/chirpstack/blob/master/chirpstack/src/storage/mod.rs)

In the go-redis client there is a universal client that allows you setup either a normal/cluster/sentinel client depending on the config you give. See https://redis.uptrace.dev/guide/universal.html

Would you be open to accepting a PR for a universal redis client in deadpool-redis?
This would prevent code duplication in users of deadpool-redis and would allow them to easily switch between normal/cluster/sentinel clients

@bikeshedder
Copy link
Owner

Sure thing. I always wondered why there needed to be three distinct pools for that. I only use a single redis instance so I've never actually bothered with redis cluster/sentinel. It is purely driven by PRs from the community.

@bikeshedder bikeshedder added enhancement New feature or request A-redis Area: Redis / deadpool-redis labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-redis Area: Redis / deadpool-redis enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants