This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… translation-1500-feature-deriv-prime
… translation-1500-feature-deriv-prime
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aswathy-deriv
requested review from
habib-deriv,
yashim-deriv,
prince-deriv,
mohsen-deriv,
mohammad-hashemi-deriv,
mitra-deriv and
fasihali-deriv
as code owners
August 10, 2023 09:53
12 tasks
… translation-1500-feature-deriv-prime
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deriv-com-git-translation-1500-feature-deriv-prime.binary.sx/ |
… translation-1500-feature-deriv-prime
… translation-1500-feature-deriv-prime
* feat: deriv prime connectivity * feat: seo documentation * fix: seo header tag added * fix: replaced the type prop for paragraph * fix: added the classname for the typography header
* feat: meet us there section * fix: types on different file * fix: review comments * chore: vercel * fix: staticimage usage * chore: vercel * fix: alt text localize and fix font family * fix: margin top * fix: subtasks --------- Co-authored-by: Konstantinos-Gk <[email protected]>
* fix: fixed table layout and typescript issue * fix: added layout to faq table
habib-deriv
previously approved these changes
Sep 1, 2023
fasihali-deriv
previously approved these changes
Sep 1, 2023
….com/binary-com/deriv-com into translation-1500-feature-deriv-prime
aswathy-deriv
dismissed stale reviews from fasihali-deriv and habib-deriv
via
September 1, 2023 06:05
3bd1849
habib-deriv
previously approved these changes
Sep 1, 2023
fasihali-deriv
approved these changes
Sep 1, 2023
mayuran-deriv
approved these changes
Sep 1, 2023
… translation-1500-feature-deriv-prime
fasihali-deriv
previously approved these changes
Sep 1, 2023
mayuran-deriv
approved these changes
Sep 1, 2023
habib-deriv
approved these changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Type of change