This repository has been archived by the owner on Sep 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 185
Konstantinos/DPROD-3579/Accumulators Rest of the sections of options page #7153
Closed
konstantinosG-deriv
wants to merge
18
commits into
binary-com:master
from
konstantinosG-deriv:translation-3600-options-revamp-part-1
Closed
Konstantinos/DPROD-3579/Accumulators Rest of the sections of options page #7153
konstantinosG-deriv
wants to merge
18
commits into
binary-com:master
from
konstantinosG-deriv:translation-3600-options-revamp-part-1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Running Lighthouse audit... |
…onstantinosG-deriv/deriv-com into translation-3600-options-revamp-part-1
konstantinosG-deriv
requested review from
habib-deriv,
yashim-deriv,
prince-deriv,
mitra-deriv and
fasihali-deriv
as code owners
February 27, 2024 12:57
hasan-deriv
reviewed
Feb 28, 2024
src/features/pages/options/accumulator/accumulators_faq.module.scss
Outdated
Show resolved
Hide resolved
src/features/components/organisms/what-are-digital-options/index.tsx
Outdated
Show resolved
Hide resolved
🚀 Smoke test run (2) passed successfully! |
🚀 Smoke test run (4) passed successfully! |
🚀 Smoke test run (1) passed successfully! |
hasan-deriv
approved these changes
Feb 28, 2024
🚀 Smoke test run (3) passed successfully! |
🚀 Smoke test run (1) passed successfully! |
🚀 Smoke test run (4) passed successfully! |
🚀 Smoke test run (2) passed successfully! |
🚀 Smoke test run (5) passed successfully! |
Deployment failed with the following error:
|
|
|
|
|
Quality Gate passedIssues Measures |
Preview Link: https://translation-3600-opt.deriv-com-preview-links.pages.dev
|
dan-deriv
approved these changes
Mar 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Revamp accumulators page first half
Type of change