Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seal ignores PRs with the same title #145

Open
suzannehamilton opened this issue Feb 21, 2017 · 1 comment
Open

Seal ignores PRs with the same title #145

suzannehamilton opened this issue Feb 21, 2017 · 1 comment

Comments

@suzannehamilton
Copy link
Contributor

If you have several pull requests with the same title (e.g. because you've fixed the same issue in different projects), the seal only reports one of them.

I suspect this is because GithubFetcher returns a hash of the PRs with the title as the key. Line 26:

pull_requests[pull_request.title] = present_pull_request(pull_request, repo_name)
@strangeminds
Copy link

We fixed the duplicate title issue with pull requests by changing that line to:

pull_requests["#{pull_request.title} (#{pull_request.number})"] = present_pull_request(pull_request, repo_name)

LiveWorld@5a32be2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants