Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document v1/v2 split and motivation for moving away from serde #541

Open
mwcampbell opened this issue Apr 30, 2022 · 4 comments
Open

Document v1/v2 split and motivation for moving away from serde #541

mwcampbell opened this issue Apr 30, 2022 · 4 comments

Comments

@mwcampbell
Copy link

As a newcomer to this project, I was confused at first, because the README only barely mentioned the split between v1 and v2. Also, as far as I can tell, the motivation for moving away from serde in v2 isn't documented. I'm curious about the motivation because serde is a critical part of the Rust ecosystem, and I'm afraid that requiring structs to implement or derive bincode-specific traits will be a step backward for bincode, but I'm sure there's a good reason.

@BarbossHack
Copy link

BarbossHack commented May 4, 2022

note that you can still add the "serde" feature in v2

@VictorKoenders
Copy link
Contributor

We have a list of known issues with serde on docs.rs. There are some other reasons we wanted to make the serde dependency optional (supporting embedded targets, reducing dependencies, increasing performance). We can add a FAQ to the repo with these reasons.

@stale
Copy link

stale bot commented Aug 14, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Aug 14, 2022
@richardpringle
Copy link
Contributor

I'd love to see a little write-up into the decision-making process beyond solving for the "known issues" with serve in the docs.

This would help me for two reasons:

  1. Help me decide whether bincode's goals as an encoding format are aligned with what I need it for
  2. Help me re-evaluate some of my own decisions around the use of serde

It wouldn't need to be perfect nor even accurately reflect the discussions that took place, but it there's something that can help with the above (namely 2, I think most of your other documentation covers 1, but it would still give me some insight), that would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants