Skip to content

Commit

Permalink
implements workaround for #51
Browse files Browse the repository at this point in the history
  • Loading branch information
huettenhain committed Jul 6, 2024
1 parent 8d5dceb commit 30d24be
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
1 change: 0 additions & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ jobs:
run: |
python -m pip install --upgrade pip
python -m pip install flake8
python -m pip install dictdumper==0.8.4
pip install .[all]
- name: Unit tests
if: ${{ matrix.os != 'ubuntu-latest' }}
Expand Down
8 changes: 8 additions & 0 deletions refinery/units/formats/pcap.py
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@ def _pcapkit():
import pcapkit
return pcapkit

@Unit.Requires('dictdumper==0.8.4', 'all')
def _pcapkit_python37_bugfix():
"""
TODO: This artificial requirement pins a dependency of pypcapkit that otherwise breaks for
Python 3.7; see issue [#51](https://github.com/binref/refinery/issues/51). Once that issue
is resolved, this should be removed.
"""

def process(self, data):
with NoLogging():
pcapkit = self._pcapkit
Expand Down

0 comments on commit 30d24be

Please sign in to comment.