You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem
I use this integration with home assistant automations to trun on and off batteries or charge them over night. However sometimes changing mode fails to run due to communication error (either caused by transient network error or some other causes - it doesn't matter). In automation i made steps to continue on error and wrapped with repeat-until loop to ensure proper state is set. However automation still breaks as continue_on_error functionality ignores only HomeAssistantError type, while this automation throws Modbus Error.
Expectation
I'd like that this automation throw HomeAssistantError on error rather than raw exceptions so continue_on_error could be used.
Hello,
Problem
I use this integration with home assistant automations to trun on and off batteries or charge them over night. However sometimes changing mode fails to run due to communication error (either caused by transient network error or some other causes - it doesn't matter). In automation i made steps to continue on error and wrapped with repeat-until loop to ensure proper state is set. However automation still breaks as continue_on_error functionality ignores only HomeAssistantError type, while this automation throws Modbus Error.
Expectation
I'd like that this automation throw HomeAssistantError on error rather than raw exceptions so continue_on_error could be used.
See here:
https://github.com/home-assistant/core/blob/ba8a530d19dc3e93602275961de46d700611f4a1/homeassistant/helpers/script.py#L493
https://community.home-assistant.io/t/continue-on-error-not-working/429947/6
The text was updated successfully, but these errors were encountered: