Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoring Sheet Viewer: Refactor #6996

Open
janezd opened this issue Jan 19, 2025 · 0 comments
Open

Scoring Sheet Viewer: Refactor #6996

janezd opened this issue Jan 19, 2025 · 0 comments
Labels
bug A bug confirmed by the core team

Comments

@janezd
Copy link
Contributor

janezd commented Jan 19, 2025

What's wrong?

_class_combo_changed (https://github.com/biolab/orange3/blob/master/Orange/widgets/visualize/owscoringsheetviewer.py#L446C9-L446C29) checks whether the class indeed changed and if so, they (indirectly) call https://github.com/biolab/orange3/blob/master/Orange/widgets/visualize/owscoringsheetviewer.py#L459, which just negates some coefficients and subtracts risks from 100. I don't think this is very safe.

Switching back and forth can easily go wrong. The widget should remember the values for one target and use them to compute that values for the shown target. I suspect this may be the reason for failing test (see e.g. #6995).

How can we reproduce the problem?

Test fails randomly, but apparently only on github CI, not locally.

@janezd janezd added bug report Bug is reported by user, not yet confirmed by the core team bug A bug confirmed by the core team and removed bug report Bug is reported by user, not yet confirmed by the core team labels Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug confirmed by the core team
Projects
None yet
Development

No branches or pull requests

1 participant