[FIX] io_util: Detect utf-8-sig when using file utility
#7006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7006 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 332 332
Lines 73333 73341 +8
=======================================
+ Hits 64889 64897 +8
Misses 8444 8444 |
ales-erjavec
force-pushed
the
table-reader-utf-8-sig
branch
from
2fd00d0 to
a714864
Compare
ales-erjavec
force-pushed
the
table-reader-utf-8-sig
branch
from
a714864 to
2df43bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Detect utf-8-sig when using file utility.
Fixes #7000
Note: An alternative would be to remove the use of
fileutility, chardet would recognize the BOM (and does so on windows where file is typically not available).Description of changes
Detect utf-8-sig when using file utility.
Includes