Lint rule idea noDynamicNamespaceImportAccess

[minht11]

I haven't found any rule like that when I searched for it briefly, so this might be new rule.
Disallow dynamic access of namespaced imports. For example we use ParaglideJS and it export its i18n keys like this:

import * as m from './messages'

Under the hood each key is separate file, so Rollup is able to tree shake them, however if we use it as dynamic map:

m[dynamicKey]

The whole object must be inlined and bundle size would explode.
In this more contrived example, people might pull whole react lib instead of one hook:

import * as React from 'react'

React['useState']

So I would propose adding new lint rule, which disallows dynamic access on namespaced imports, this would be less restrictive version of https://biomejs.dev/linter/rules/no-namespace-import/

[Conaclos]

useLiteralKeys will report this pattern. Do you think we really need a specific rule here? If we add this rule, I think we should still allow computed key that are not identifiers such as React["@special"].

[minht11]

Will it report cases like this:

import * as m from './messages'

const someComputedKeyOrEvenExternalProperty = ...

const value = m[someComputedKeyOrEvenExternalProperty]

Its not only about literals, its about any non static property access which bundler would not be able to treeshake.

[Conaclos]

You are right. Look like a good rule. Feel free to open an issue to implement this.

[minht11]

I just remembered that we use auto import, so for my case it would not really help, because code like this:

import * as m from './messages'
const value =  m[someComputedKeyOrEvenExternalProperty]

becomes:

const value =  m[someComputedKeyOrEvenExternalProperty]

variable m is auto imported. So my proposed rule would not work.

While I think rule by itself is useful, what do you think adding general rule noDynamicPropertyAccess which would allow user to specify custom object names, which should disallow such access, it also could have option to disallow namespaced import access.

1. Do you think noDynamicPropertyAccess rule could be added to biome? With option to customize what things to match?
2. If general rule is added should noDynamicNamespaceImportAccess be merged under it or remain separate?