Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 --colors option broken #3824

Open
1 task done
hyperknot opened this issue Sep 8, 2024 · 2 comments
Open
1 task done

🐛 --colors option broken #3824

hyperknot opened this issue Sep 8, 2024 · 2 comments

Comments

@hyperknot
Copy link

Environment information

pnpm biome rage
CLI:
  Version:                      1.8.3
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.17.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/9.9.0"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

--colors option is broken in CLI

  1. Autodetect doesn't detect piped output with | cat, it still sends color characters.
  2. --colors=off doesn't turn colors off (might be the actual reason behind 1.)

Currently the output cannot be grepped correctly, because of all the decoration characters beint sent to grep, etc.

Expected result

Colors should turn off either with | cat or with --colors=off

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@ematipico
Copy link
Member

Please provide a reproduction, or instructions to reproduce it on our machines

@hyperknot
Copy link
Author

hyperknot commented Sep 8, 2024

  1. pnpm i @biomejs/biome
  2. pnpm biome check --colors=off --log-level=info --log-kind=pretty . | cat

Colors are still present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants