Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💅 Suppression comment fails with inner comments in functions #4519

Open
1 task done
maxmorozoff opened this issue Nov 12, 2024 · 2 comments
Open
1 task done

💅 Suppression comment fails with inner comments in functions #4519

maxmorozoff opened this issue Nov 12, 2024 · 2 comments
Assignees
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug

Comments

@maxmorozoff
Copy link

maxmorozoff commented Nov 12, 2024

Environment information

(edited)

CLI:
  Version:                      1.9.4

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Linter:
  JavaScript enabled:           true
  JSON enabled:                 true
  CSS enabled:                  true
  GraphQL enabled:              false
  Recommended:                  true
  All:                          false

Rule name

lint/complexity/useArrowFunction

Playground link

https://biomejs.dev/playground/?code=LwAvACAAYgBpAG8AbQBlAC0AaQBnAG4AbwByAGUAIABsAGkAbgB0AC8AYwBvAG0AcABsAGUAeABpAHQAeQAvAHUAcwBlAEEAcgByAG8AdwBGAHUAbgBjAHQAaQBvAG4AOgAgAFQAaABpAHMAIABjAG8AbQBtAGUAbgB0ACAAZABvAGUAcwAgAG4AbwB0ACAAdwBvAHIAawAgAHcAaQB0AGgAIABhAG4AIABpAG4AbgBlAHIAIABjAG8AbQBtAGUAbgB0ACAAaQBuACAAdABoAGUAIABmAHUAbgBjAHQAaQBvAG4ACgBjAG8AbgBzAHQAIABmAG8AbwAwACAAPQAgAGYAdQBuAGMAdABpAG8AbgAgACgAYgBhAHIAOgAgAHMAdAByAGkAbgBnACkAIAB7AAoACQAvAC8AIABiAGkAbwBtAGUALQBpAGcAbgBvAHIAZQAgAGwAaQBuAHQALwBzAHQAeQBsAGUALwBuAG8AUABhAHIAYQBtAGUAdABlAHIAQQBzAHMAaQBnAG4AOgAgAFQAaABpAHMAIABjAG8AbQBtAGUAbgB0ACAAdwBvAHIAawBzAAoACQBiAGEAcgAgAD0AIAAiAGIAYQB6ACIAOwAKAH0AOwAKAAoAYwBvAG4AcwB0ACAAZgBvAG8AMQAgAD0AIABmAHUAbgBjAHQAaQBvAG4AIAAoAGIAYQByADoAIABzAHQAcgBpAG4AZwApACAAewAKAAkALwAvACAAYgBpAG8AbQBlAC0AaQBnAG4AbwByAGUAIABsAGkAbgB0AC8AcwB0AHkAbABlAC8AbgBvAFAAYQByAGEAbQBlAHQAZQByAEEAcwBzAGkAZwBuADoAIABUAGgAaQBzACAAYwBvAG0AbQBlAG4AdAAgAHcAbwByAGsAcwAKAAkAYgBhAHIAIAA9ACAAIgBiAGEAegAiADsACgB9ADsACgAKAC8ALwAgAGIAaQBvAG0AZQAtAGkAZwBuAG8AcgBlACAAbABpAG4AdAAvAGMAbwBtAHAAbABlAHgAaQB0AHkALwB1AHMAZQBBAHIAcgBvAHcARgB1AG4AYwB0AGkAbwBuADoAIABUAGgAaQBzACAAYwBvAG0AbQBlAG4AdAAgAHcAbwByAGsAcwAgAGkAZgAgAHQAaABlAHIAZQAgAGkAcwAgAG4AbwAgAGkAbgBuAGUAcgAgAGMAbwBtAG0AZQBuAHQAIABpAG4AIAB0AGgAZQAgAGYAdQBuAGMAdABpAG8AbgAKAGMAbwBuAHMAdAAgAGYAbwBvADIAIAA9ACAAZgB1AG4AYwB0AGkAbwBuACAAKABiAGEAcgA6ACAAcwB0AHIAaQBuAGcAKQAgAHsACgAJAGIAYQByACAAPQAgACIAYgBhAHoAIgA7AAoAfQA7AAoACgAvAC8AIABiAGkAbwBtAGUALQBpAGcAbgBvAHIAZQAgAGwAaQBuAHQALwBjAG8AbQBwAGwAZQB4AGkAdAB5AC8AdQBzAGUAQQByAHIAbwB3AEYAdQBuAGMAdABpAG8AbgA6ACAAVABoAGkAcwAgAGMAbwBtAG0AZQBuAHQAIAB3AG8AcgBrAHMAIABpAGYAIAB0AGgAZQByAGUAIABpAHMAIABuAG8AIABpAG4AbgBlAHIAIABjAG8AbQBtAGUAbgB0ACAAaQBuACAAdABoAGUAIABmAHUAbgBjAHQAaQBvAG4ACgBjAG8AbgBzAHQAIABmAG8AbwAzACAAPQAgAGYAdQBuAGMAdABpAG8AbgAgACgAKQAgAHsACgAgACAAIAAgAC8ALwAgAGIAaQBvAG0AZQAtAGkAZwBuAG8AcgBlACAAbABpAG4AdAAvAHMAdQBzAHAAaQBjAGkAbwB1AHMALwBuAG8ARQB4AHAAbABpAGMAaQB0AEEAbgB5ADoAIABUAGgAaQBzACAAYwBvAG0AbQBlAG4AdAAgAHcAbwByAGsAcwAKACAAIAAgACAAbABlAHQAIABiAGEAcgA6ACAAYQBuAHkAOwAKAH0AOwAKAA%3D%3D

Expected result

The biome-ignore directive should consistently suppress linting errors regardless of inner comments.

Code of Conduct

  • I agree to follow Biome's Code of Conduct
@maxmorozoff maxmorozoff added the S-Needs triage Status: this issue needs to be triaged label Nov 12, 2024
@dyc3 dyc3 added S-Bug-confirmed Status: report has been confirmed as a valid bug A-Linter Area: linter L-JavaScript Language: JavaScript and super languages labels Nov 12, 2024
@github-actions github-actions bot removed the S-Needs triage Status: this issue needs to be triaged label Nov 12, 2024
@maxmorozoff
Copy link
Author

There is a workaround if someone needs to ignore warnings in similar cases: opennextjs/opennextjs-aws#628 (comment)

@fireairforce
Copy link
Contributor

i'd like to work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Linter Area: linter L-JavaScript Language: JavaScript and super languages S-Bug-confirmed Status: report has been confirmed as a valid bug
Projects
None yet
Development

No branches or pull requests

3 participants