🐛 Setting indent_size to tab in .editorconfig causes error

[jonasgeiler]

Environment information

CLI:
  Version:                      1.9.4
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_PATH:               unset
  BIOME_LOG_PREFIX_NAME:        unset
  BIOME_CONFIG_PATH:            unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.18.2"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

1. I have the following .editorconfig file:

   root = true
   
   [*]
   indent_style             = tab
   indent_size              = tab
   #tab_width               = 4
   end_of_line              = lf
   charset                  = utf-8
   trim_trailing_whitespace = true
   insert_final_newline     = true
   max_line_length          = 80

   I usually set indent_size to tab and comment out tab_width, so that it will use the tab width configured in the editor of the user.

2. I have set formatter/useEditorconfig to true in biome.json, so it uses the .editorconfig file above.

3. Running biome check now shows the following error and does nothing else:

   configuration ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
   
     ✖ Failed to parse the .editorconfig file.
    
       Caused by:
         Custom("invalid digit found in string")
   

4. If I set indent_size to 4, everything works again, but according to https://editorconfig.org and their detailed document, setting indent_size to tab is perfectly valid and should be supported. I also noticed that the tab_width setting is currently not being parsed by Biome, it looks like, so that may have to be done first.

Expected result

It should accept indent_size = tab in .editorconfig and use the value of tab_width, or a default, and not throw an error.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[ematipico]

It seems that tab is a supported value: https://github.com/editorconfig/editorconfig/wiki/EditorConfig-Properties#indent_size

[dyc3]

I want to note that this should be used as the source of truth for the editorconfig spec: https://spec.editorconfig.org/

[ematipico]

Yeah, also that web page mentions very briefly that the value is accepted. However, the wording is very weird for me