Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapting to NAOqi 2.9 #1

Open
wants to merge 30 commits into
base: naoqi2.9
Choose a base branch
from
Open

Adapting to NAOqi 2.9 #1

wants to merge 30 commits into from

Conversation

victorpaleologue
Copy link
Collaborator

I know it is not ready for merging yet, but please tell us what you feel is the most important to fix.

jeromebruzaud and others added 30 commits June 28, 2019 12:08
@jeromebruzaud
added some debugging messages
a239c55
@jeromebruzaud
add some debugging print
a7276ea
@jeromebruzaud
renamed recognitionMemory.recognise() to ...recognise_mem()
f4edd24
@jeromebruzaud
changed result from NAOqi Face Recognition to dummy data
33dc7e4
@jeromebruzaud
removed use of the old NAOqi face recognition system
d0ef456
@jeromebruzaud
removed not very useful variable
574d433
@jeromebruzaud
change logic so that new person can be registered automatically
7b1fea7 
 without the tablet
@jeromebruzaud
remove call to say and animation (part 1)
6ce357e
@jeromebruzaud
removed unecessary intermediary method startRecognition()
07053b6
@jeromebruzaud
make picture shot optional
b9c2d28
@jeromebruzaud
add callable methods to give facial recognition results (from outside)
4a84eab
@jeromebruzaud
fix recogniseSilent that would not continue when recognising new person
85b26ae 
Note: onFaceDetected's logic is bloated, confirmation should be performed
just after recognition
@jeromebruzaud
fixed the onFaceDetected logic
071af38
@jeromebruzaud
fix recogniseSilent stopping the loop after recognition
2e11a92
@jeromebruzaud
removed isMemoryRobot and isMemoryOnRobot unecessary booleans
ab21079
@jeromebruzaud
fix registration logic (in recognitionModule.recognise, onFaceDetecte…
fd3c537 
…d) and code cleaning in confirmRecognition
@jeromebruzaud
fixed name generator so it gives name not already in database
099c38f
@jeromebruzaud
cleaning booleans and reworked confirmRegistration code and subsequen…
595c2b6 
…t methods in RecognitionMemory

PLEASE TEST THOUROUGHLY
@jeromebruzaud
broken
737b00a
@jeromebruzaud
fix bad id given to setPersonIdentity during initial BN training
e666d1d
@jeromebruzaud
fix confirmRecognitionSilent not loading Database
966531d
@jeromebruzaud
trying to fix ID issue
cfe9c06
@jeromebruzaud
temp
144f60e
@jeromebruzaud
fix id value. IT IS WORKINNNNGGGGG
5f3c946
@jeromebruzaud
remove all unecessary from Module
82c6adb
@jeromebruzaud
remove connectToRobot in Memory
4db8982
@jeromebruzaud
cleaning Memory
02adc0b
@jeromebruzaud
cleaning Memory but not sure
5d9adbd
@jeromebruzaud
WIP
f363031
Recognition Module: add some comment
94facc1
@victorpaleologue
Copy link
Collaborator Author

I would like to test it but I fail to make this work.
I scp-ed everything, but I am missing the stk module.
How to get it and bring it with the rest of the project?

@birfan
Copy link
Owner

birfan commented Sep 5, 2019

I would like to test it but I fail to make this work.
I scp-ed everything, but I am missing the stk module.
How to get it and bring it with the rest of the project?

stk folder is under recognition-service/scripts/ folder. If you are uploading files to the robot, you can use the readme file in recognition-service folder to first send those service files to the robot using Choregraphe and then send the recognition memory files with scp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victorpaleologue @birfan @jeromebruzaud