Implement query_exactly_one #214
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. tbf the whole Token::Error hierarchy would need a refresh |
|
The capi build failure is being worked on, I think |
|
If that’s ok with you, I will rebase the PR on top of |
|
Superseded by #260 thanks for opening this PR and sorry for the time it stayed open, work on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement query exactly one to make it easier to work with single-fact queries.
Added relevant doctest and unittests. This should close #187
As a side note, a lot of errors in Token::Error don't expose the underlying error (e.g. RunLimit) in their error message. Is this intentional?