From e6e29e3c94c65a87df2d05cca54591f41a571636 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Fri, 11 Oct 2024 10:43:49 +0100 Subject: [PATCH 1/3] scripted-diff: Clarify "user agent" variable name This change allows to the use of the `CLIENT_` namespace without potential name clashes. -BEGIN VERIFY SCRIPT- sed -i "s/\/UA_NAME/g" $( git grep -l "CLIENT_NAME" ./src) -END VERIFY SCRIPT- --- src/clientversion.cpp | 2 +- src/clientversion.h | 2 +- src/init.cpp | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/clientversion.cpp b/src/clientversion.cpp index 3943c4fb1d4..7cdbda7de21 100644 --- a/src/clientversion.cpp +++ b/src/clientversion.cpp @@ -20,7 +20,7 @@ using util::Join; * for both bitcoind and bitcoin-qt, to make it harder for attackers to * target servers or GUI users specifically. */ -const std::string CLIENT_NAME("Satoshi"); +const std::string UA_NAME("Satoshi"); #include diff --git a/src/clientversion.h b/src/clientversion.h index d1202b1259a..03b96d0124a 100644 --- a/src/clientversion.h +++ b/src/clientversion.h @@ -33,7 +33,7 @@ static const int CLIENT_VERSION = + 100 * CLIENT_VERSION_MINOR + 1 * CLIENT_VERSION_BUILD; -extern const std::string CLIENT_NAME; +extern const std::string UA_NAME; std::string FormatFullVersion(); diff --git a/src/init.cpp b/src/init.cpp index 587e7cb42b5..74a69e324ac 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -1464,7 +1464,7 @@ bool AppInitMain(NodeContext& node, interfaces::BlockAndHeaderTipInfo* tip_info) return InitError(strprintf(_("User Agent comment (%s) contains unsafe characters."), cmt)); uacomments.push_back(cmt); } - strSubVersion = FormatSubVersion(CLIENT_NAME, CLIENT_VERSION, uacomments); + strSubVersion = FormatSubVersion(UA_NAME, CLIENT_VERSION, uacomments); if (strSubVersion.size() > MAX_SUBVERSION_LENGTH) { return InitError(strprintf(_("Total length of network version string (%i) exceeds maximum length (%i). Reduce the number or size of uacomments."), strSubVersion.size(), MAX_SUBVERSION_LENGTH)); From 332655cb52c8f8ef64b29b09e38ef5d61235ed21 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Thu, 24 Oct 2024 16:39:39 +0100 Subject: [PATCH 2/3] build: Rename `PACKAGE_*` variables to `CLIENT_*` The use of `PACKAGE_NAME` for the project's variable name is problematic, as this name is commonly used in CMake's interface variables. If third-party CMake code handles with scopes improperly, our `PACKAGE_NAME` variable could end up with an unexpected value. This change avoids such conflicts by renaming all `PACKAGE_*` variables to `CLIENT_*`. --- CMakeLists.txt | 10 ++++---- cmake/bitcoin-build-config.h.in | 8 +++--- cmake/module/GenerateSetupNsi.cmake | 4 +-- cmake/module/Maintenance.cmake | 4 +-- doc/Doxyfile.in | 2 +- libbitcoinkernel.pc.in | 4 +-- share/setup.nsi.in | 40 ++++++++++++++--------------- test/config.ini.in | 4 +-- 8 files changed, 38 insertions(+), 38 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 33fb4f64abb..67cb35ddcc9 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -16,7 +16,7 @@ endif() #============================= # Project / Package metadata #============================= -set(PACKAGE_NAME "Bitcoin Core") +set(CLIENT_NAME "Bitcoin Core") set(CLIENT_VERSION_MAJOR 28) set(CLIENT_VERSION_MINOR 99) set(CLIENT_VERSION_BUILD 0) @@ -47,14 +47,14 @@ project(BitcoinCore LANGUAGES NONE ) -set(PACKAGE_VERSION ${PROJECT_VERSION}) +set(CLIENT_VERSION_STRING ${PROJECT_VERSION}) if(CLIENT_VERSION_RC GREATER 0) - string(APPEND PACKAGE_VERSION "rc${CLIENT_VERSION_RC}") + string(APPEND CLIENT_VERSION_STRING "rc${CLIENT_VERSION_RC}") endif() set(COPYRIGHT_HOLDERS "The %s developers") -set(COPYRIGHT_HOLDERS_FINAL "The ${PACKAGE_NAME} developers") -set(PACKAGE_BUGREPORT "https://github.com/bitcoin/bitcoin/issues") +set(COPYRIGHT_HOLDERS_FINAL "The ${CLIENT_NAME} developers") +set(CLIENT_BUGREPORT "https://github.com/bitcoin/bitcoin/issues") #============================= # Language setup diff --git a/cmake/bitcoin-build-config.h.in b/cmake/bitcoin-build-config.h.in index 094eb8040a3..6524cde1902 100644 --- a/cmake/bitcoin-build-config.h.in +++ b/cmake/bitcoin-build-config.h.in @@ -24,7 +24,7 @@ #define COPYRIGHT_HOLDERS_FINAL "@COPYRIGHT_HOLDERS_FINAL@" /* Replacement for %s in copyright holders string */ -#define COPYRIGHT_HOLDERS_SUBSTITUTION "@PACKAGE_NAME@" +#define COPYRIGHT_HOLDERS_SUBSTITUTION "@CLIENT_NAME@" /* Copyright year */ #define COPYRIGHT_YEAR @COPYRIGHT_YEAR@ @@ -124,16 +124,16 @@ #cmakedefine HAVE_VM_VM_PARAM_H 1 /* Define to the address where bug reports for this package should be sent. */ -#define PACKAGE_BUGREPORT "@PACKAGE_BUGREPORT@" +#define PACKAGE_BUGREPORT "@CLIENT_BUGREPORT@" /* Define to the full name of this package. */ -#define PACKAGE_NAME "@PACKAGE_NAME@" +#define PACKAGE_NAME "@CLIENT_NAME@" /* Define to the home page for this package. */ #define PACKAGE_URL "@PROJECT_HOMEPAGE_URL@" /* Define to the version of this package. */ -#define PACKAGE_VERSION "@PACKAGE_VERSION@" +#define PACKAGE_VERSION "@CLIENT_VERSION_STRING@" /* Define to 1 if strerror_r returns char *. */ #cmakedefine STRERROR_R_CHAR_P 1 diff --git a/cmake/module/GenerateSetupNsi.cmake b/cmake/module/GenerateSetupNsi.cmake index 3c358c54958..97a53b071db 100644 --- a/cmake/module/GenerateSetupNsi.cmake +++ b/cmake/module/GenerateSetupNsi.cmake @@ -5,8 +5,8 @@ function(generate_setup_nsi) set(abs_top_srcdir ${PROJECT_SOURCE_DIR}) set(abs_top_builddir ${PROJECT_BINARY_DIR}) - set(PACKAGE_URL ${PROJECT_HOMEPAGE_URL}) - set(PACKAGE_TARNAME "bitcoin") + set(CLIENT_URL ${PROJECT_HOMEPAGE_URL}) + set(CLIENT_TARNAME "bitcoin") set(BITCOIN_GUI_NAME "bitcoin-qt") set(BITCOIN_DAEMON_NAME "bitcoind") set(BITCOIN_CLI_NAME "bitcoin-cli") diff --git a/cmake/module/Maintenance.cmake b/cmake/module/Maintenance.cmake index 456419b7222..61251d24397 100644 --- a/cmake/module/Maintenance.cmake +++ b/cmake/module/Maintenance.cmake @@ -98,7 +98,7 @@ function(add_macos_deploy_target) file(CONFIGURE OUTPUT ${macos_app}/Contents/Resources/empty.lproj CONTENT "") configure_file(${PROJECT_SOURCE_DIR}/src/qt/res/icons/bitcoin.icns ${macos_app}/Contents/Resources/bitcoin.icns NO_SOURCE_PERMISSIONS COPYONLY) file(CONFIGURE OUTPUT ${macos_app}/Contents/Resources/Base.lproj/InfoPlist.strings - CONTENT "{ CFBundleDisplayName = \"@PACKAGE_NAME@\"; CFBundleName = \"@PACKAGE_NAME@\"; }" + CONTENT "{ CFBundleDisplayName = \"@CLIENT_NAME@\"; CFBundleName = \"@CLIENT_NAME@\"; }" ) add_custom_command( @@ -109,7 +109,7 @@ function(add_macos_deploy_target) VERBATIM ) - string(REPLACE " " "-" osx_volname ${PACKAGE_NAME}) + string(REPLACE " " "-" osx_volname ${CLIENT_NAME}) if(CMAKE_HOST_APPLE) add_custom_command( OUTPUT ${PROJECT_BINARY_DIR}/${osx_volname}.zip diff --git a/doc/Doxyfile.in b/doc/Doxyfile.in index ccaf31170a1..cbbb6551f1b 100644 --- a/doc/Doxyfile.in +++ b/doc/Doxyfile.in @@ -38,7 +38,7 @@ PROJECT_NAME = "Bitcoin Core" # could be handy for archiving the generated documentation or if some version # control system is used. -PROJECT_NUMBER = @PACKAGE_VERSION@ +PROJECT_NUMBER = @CLIENT_VERSION_STRING@ # Using the PROJECT_BRIEF tag one can provide an optional one line description # for a project that appears at the top of each page and should give viewer a diff --git a/libbitcoinkernel.pc.in b/libbitcoinkernel.pc.in index a2cb7d3692e..b8f93315874 100644 --- a/libbitcoinkernel.pc.in +++ b/libbitcoinkernel.pc.in @@ -3,9 +3,9 @@ exec_prefix=${prefix} libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@ includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@ -Name: @PACKAGE_NAME@ kernel library +Name: @CLIENT_NAME@ kernel library Description: Experimental library for the Bitcoin Core validation engine. -Version: @PACKAGE_VERSION@ +Version: @CLIENT_VERSION_STRING@ Libs: -L${libdir} -lbitcoinkernel Libs.private: -L${libdir} @LIBS_PRIVATE@ Cflags: -I${includedir} diff --git a/share/setup.nsi.in b/share/setup.nsi.in index f22e256967e..d1a85cdb7f3 100644 --- a/share/setup.nsi.in +++ b/share/setup.nsi.in @@ -1,4 +1,4 @@ -Name "@PACKAGE_NAME@ (64-bit)" +Name "@CLIENT_NAME@ (64-bit)" RequestExecutionLevel highest SetCompressor /SOLID lzma @@ -11,8 +11,8 @@ Unicode true # General Symbol Definitions !define REGKEY "SOFTWARE\$(^Name)" -!define COMPANY "@PACKAGE_NAME@ project" -!define URL @PACKAGE_URL@ +!define COMPANY "@CLIENT_NAME@ project" +!define URL @CLIENT_URL@ # MUI Symbol Definitions !define MUI_ICON "@abs_top_srcdir@/share/pixmaps/bitcoin.ico" @@ -24,7 +24,7 @@ Unicode true !define MUI_STARTMENUPAGE_REGISTRY_ROOT HKLM !define MUI_STARTMENUPAGE_REGISTRY_KEY ${REGKEY} !define MUI_STARTMENUPAGE_REGISTRY_VALUENAME StartMenuGroup -!define MUI_STARTMENUPAGE_DEFAULTFOLDER "@PACKAGE_NAME@" +!define MUI_STARTMENUPAGE_DEFAULTFOLDER "@CLIENT_NAME@" !define MUI_FINISHPAGE_RUN "$WINDIR\explorer.exe" !define MUI_FINISHPAGE_RUN_PARAMETERS $INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@ !define MUI_UNICON "${NSISDIR}\Contrib\Graphics\Icons\modern-uninstall.ico" @@ -58,12 +58,12 @@ XPStyle on BrandingText " " ShowInstDetails show VIProductVersion @CLIENT_VERSION_MAJOR@.@CLIENT_VERSION_MINOR@.@CLIENT_VERSION_BUILD@.0 -VIAddVersionKey ProductName "@PACKAGE_NAME@" -VIAddVersionKey ProductVersion "@PACKAGE_VERSION@" +VIAddVersionKey ProductName "@CLIENT_NAME@" +VIAddVersionKey ProductVersion "@CLIENT_VERSION_STRING@" VIAddVersionKey CompanyName "${COMPANY}" VIAddVersionKey CompanyWebsite "${URL}" -VIAddVersionKey FileVersion "@PACKAGE_VERSION@" -VIAddVersionKey FileDescription "Installer for @PACKAGE_NAME@" +VIAddVersionKey FileVersion "@CLIENT_VERSION_STRING@" +VIAddVersionKey FileDescription "Installer for @CLIENT_NAME@" VIAddVersionKey LegalCopyright "Copyright (C) 2009-@COPYRIGHT_YEAR@ @COPYRIGHT_HOLDERS_FINAL@" InstallDirRegKey HKCU "${REGKEY}" Path ShowUninstDetails show @@ -95,23 +95,23 @@ Section -post SEC0001 !insertmacro MUI_STARTMENU_WRITE_BEGIN Application CreateDirectory $SMPROGRAMS\$StartMenuGroup CreateShortcut "$SMPROGRAMS\$StartMenuGroup\$(^Name).lnk" $INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@ - CreateShortcut "$SMPROGRAMS\$StartMenuGroup\@PACKAGE_NAME@ (testnet).lnk" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" "-testnet" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" 1 - CreateShortcut "$SMPROGRAMS\$StartMenuGroup\@PACKAGE_NAME@ (test signet).lnk" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" "-signet" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" 2 - CreateShortcut "$SMPROGRAMS\$StartMenuGroup\@PACKAGE_NAME@ (testnet4).lnk" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" "-testnet4" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" 3 + CreateShortcut "$SMPROGRAMS\$StartMenuGroup\@CLIENT_NAME@ (testnet).lnk" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" "-testnet" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" 1 + CreateShortcut "$SMPROGRAMS\$StartMenuGroup\@CLIENT_NAME@ (test signet).lnk" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" "-signet" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" 2 + CreateShortcut "$SMPROGRAMS\$StartMenuGroup\@CLIENT_NAME@ (testnet4).lnk" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" "-testnet4" "$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" 3 CreateShortcut "$SMPROGRAMS\$StartMenuGroup\Uninstall $(^Name).lnk" $INSTDIR\uninstall.exe !insertmacro MUI_STARTMENU_WRITE_END WriteRegStr HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name)" DisplayName "$(^Name)" - WriteRegStr HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name)" DisplayVersion "@PACKAGE_VERSION@" + WriteRegStr HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name)" DisplayVersion "@CLIENT_VERSION_STRING@" WriteRegStr HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name)" Publisher "${COMPANY}" WriteRegStr HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name)" URLInfoAbout "${URL}" WriteRegStr HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name)" DisplayIcon $INSTDIR\bitcoin-qt.exe WriteRegStr HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name)" UninstallString $INSTDIR\uninstall.exe WriteRegDWORD HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name)" NoModify 1 WriteRegDWORD HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name)" NoRepair 1 - WriteRegStr HKCR "@PACKAGE_TARNAME@" "URL Protocol" "" - WriteRegStr HKCR "@PACKAGE_TARNAME@" "" "URL:Bitcoin" - WriteRegStr HKCR "@PACKAGE_TARNAME@\DefaultIcon" "" $INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@ - WriteRegStr HKCR "@PACKAGE_TARNAME@\shell\open\command" "" '"$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" "%1"' + WriteRegStr HKCR "@CLIENT_TARNAME@" "URL Protocol" "" + WriteRegStr HKCR "@CLIENT_TARNAME@" "" "URL:Bitcoin" + WriteRegStr HKCR "@CLIENT_TARNAME@\DefaultIcon" "" $INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@ + WriteRegStr HKCR "@CLIENT_TARNAME@\shell\open\command" "" '"$INSTDIR\@BITCOIN_GUI_NAME@@EXEEXT@" "%1"' SectionEnd # Macro for selecting uninstaller sections @@ -142,9 +142,9 @@ Section -un.post UNSEC0001 DeleteRegKey HKCU "SOFTWARE\Microsoft\Windows\CurrentVersion\Uninstall\$(^Name)" Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\Uninstall $(^Name).lnk" Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\$(^Name).lnk" - Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\@PACKAGE_NAME@ (testnet).lnk" - Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\@PACKAGE_NAME@ (testnet4).lnk" - Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\@PACKAGE_NAME@ (test signet).lnk" + Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\@CLIENT_NAME@ (testnet).lnk" + Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\@CLIENT_NAME@ (testnet4).lnk" + Delete /REBOOTOK "$SMPROGRAMS\$StartMenuGroup\@CLIENT_NAME@ (test signet).lnk" Delete /REBOOTOK "$SMSTARTUP\Bitcoin.lnk" Delete /REBOOTOK $INSTDIR\uninstall.exe Delete /REBOOTOK $INSTDIR\debug.log @@ -153,7 +153,7 @@ Section -un.post UNSEC0001 DeleteRegValue HKCU "${REGKEY}" Path DeleteRegKey /IfEmpty HKCU "${REGKEY}\Components" DeleteRegKey /IfEmpty HKCU "${REGKEY}" - DeleteRegKey HKCR "@PACKAGE_TARNAME@" + DeleteRegKey HKCR "@CLIENT_TARNAME@" RmDir /REBOOTOK $SMPROGRAMS\$StartMenuGroup RmDir /REBOOTOK $INSTDIR Push $R0 diff --git a/test/config.ini.in b/test/config.ini.in index 291599da452..7e658d3a869 100644 --- a/test/config.ini.in +++ b/test/config.ini.in @@ -6,8 +6,8 @@ # test/*/test_runner.py and test/util/rpcauth-test.py [environment] -PACKAGE_NAME=@PACKAGE_NAME@ -PACKAGE_BUGREPORT=@PACKAGE_BUGREPORT@ +PACKAGE_NAME=@CLIENT_NAME@ +PACKAGE_BUGREPORT=@CLIENT_BUGREPORT@ SRCDIR=@abs_top_srcdir@ BUILDDIR=@abs_top_builddir@ EXEEXT=@EXEEXT@ From 70713303b6399e0627c1960da4fbab48f9cf71e7 Mon Sep 17 00:00:00 2001 From: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> Date: Sat, 26 Oct 2024 13:27:25 +0100 Subject: [PATCH 3/3] scripted-diff: Rename `PACKAGE_*` variables to `CLIENT_*` This change ensures consistent use of the `CLIENT_` namespace everywhere in the repository. -BEGIN VERIFY SCRIPT- ren() { sed -i "s/\<$1\>/$2/g" $( git grep -l "$1" ./cmake ./src :\(exclude\)./src/secp256k1 ./test ) ; } ren PACKAGE_NAME CLIENT_NAME ren PACKAGE_VERSION CLIENT_VERSION_STRING ren PACKAGE_URL CLIENT_URL ren PACKAGE_BUGREPORT CLIENT_BUGREPORT -END VERIFY SCRIPT- --- cmake/bitcoin-build-config.h.in | 8 +++---- src/addrdb.cpp | 4 ++-- src/addrman.cpp | 2 +- src/bitcoin-cli-res.rc | 6 ++--- src/bitcoin-cli.cpp | 8 +++---- src/bitcoin-tx-res.rc | 4 ++-- src/bitcoin-tx.cpp | 2 +- src/bitcoin-util-res.rc | 4 ++-- src/bitcoin-util.cpp | 2 +- src/bitcoin-wallet-res.rc | 6 ++--- src/bitcoin-wallet.cpp | 4 ++-- src/bitcoind-res.rc | 4 ++-- src/bitcoind.cpp | 6 ++--- src/clientversion.cpp | 4 ++-- src/common/settings.cpp | 2 +- src/init.cpp | 6 ++--- src/init/common.cpp | 2 +- src/net.cpp | 2 +- src/qt/bitcoin.cpp | 24 +++++++++---------- src/qt/bitcoingui.cpp | 14 +++++------ src/qt/intro.cpp | 12 +++++----- src/qt/modaloverlay.cpp | 2 +- src/qt/optionsdialog.cpp | 10 ++++---- src/qt/res/bitcoin-qt-res.rc | 4 ++-- src/qt/rpcconsole.cpp | 4 ++-- src/qt/sendcoinsdialog.cpp | 6 ++--- src/qt/signverifymessagedialog.cpp | 4 ++-- src/qt/splashscreen.cpp | 2 +- src/qt/test/optiontests.cpp | 2 +- src/qt/utilitydialog.cpp | 6 ++--- src/rest.cpp | 4 ++-- src/rpc/mining.cpp | 6 ++--- src/rpc/server.cpp | 4 ++-- src/rpc/util.cpp | 4 ++-- src/util/check.cpp | 2 +- src/validation.cpp | 10 ++++---- src/wallet/rpc/backup.cpp | 2 +- src/wallet/sqlite.cpp | 2 +- src/wallet/wallet.cpp | 6 ++--- src/wallet/wallettool.cpp | 4 ++-- test/config.ini.in | 4 ++-- test/functional/feature_addrman.py | 2 +- test/functional/feature_filelock.py | 4 ++-- test/functional/feature_settings.py | 2 +- test/functional/interface_bitcoin_cli.py | 2 +- .../test_framework/test_framework.py | 2 +- test/functional/tool_wallet.py | 2 +- test/functional/wallet_multiwallet.py | 2 +- 48 files changed, 115 insertions(+), 115 deletions(-) diff --git a/cmake/bitcoin-build-config.h.in b/cmake/bitcoin-build-config.h.in index 6524cde1902..dce9261da2a 100644 --- a/cmake/bitcoin-build-config.h.in +++ b/cmake/bitcoin-build-config.h.in @@ -124,16 +124,16 @@ #cmakedefine HAVE_VM_VM_PARAM_H 1 /* Define to the address where bug reports for this package should be sent. */ -#define PACKAGE_BUGREPORT "@CLIENT_BUGREPORT@" +#define CLIENT_BUGREPORT "@CLIENT_BUGREPORT@" /* Define to the full name of this package. */ -#define PACKAGE_NAME "@CLIENT_NAME@" +#define CLIENT_NAME "@CLIENT_NAME@" /* Define to the home page for this package. */ -#define PACKAGE_URL "@PROJECT_HOMEPAGE_URL@" +#define CLIENT_URL "@PROJECT_HOMEPAGE_URL@" /* Define to the version of this package. */ -#define PACKAGE_VERSION "@CLIENT_VERSION_STRING@" +#define CLIENT_VERSION_STRING "@CLIENT_VERSION_STRING@" /* Define to 1 if strerror_r returns char *. */ #cmakedefine STRERROR_R_CHAR_P 1 diff --git a/src/addrdb.cpp b/src/addrdb.cpp index 4637906441e..889f7b3859b 100644 --- a/src/addrdb.cpp +++ b/src/addrdb.cpp @@ -150,7 +150,7 @@ bool CBanDB::Write(const banmap_t& banSet) bool CBanDB::Read(banmap_t& banSet) { if (fs::exists(m_banlist_dat)) { - LogPrintf("banlist.dat ignored because it can only be read by " PACKAGE_NAME " version 22.x. Remove %s to silence this warning.\n", fs::quoted(fs::PathToString(m_banlist_dat))); + LogPrintf("banlist.dat ignored because it can only be read by " CLIENT_NAME " version 22.x. Remove %s to silence this warning.\n", fs::quoted(fs::PathToString(m_banlist_dat))); } // If the JSON banlist does not exist, then recreate it if (!fs::exists(m_banlist_json)) { @@ -215,7 +215,7 @@ util::Result> LoadAddrman(const NetGroupManager& netgro DumpPeerAddresses(args, *addrman); } catch (const std::exception& e) { return util::Error{strprintf(_("Invalid or corrupt peers.dat (%s). If you believe this is a bug, please report it to %s. As a workaround, you can move the file (%s) out of the way (rename, move, or delete) to have a new one created on the next start."), - e.what(), PACKAGE_BUGREPORT, fs::quoted(fs::PathToString(path_addr)))}; + e.what(), CLIENT_BUGREPORT, fs::quoted(fs::PathToString(path_addr)))}; } return addrman; } diff --git a/src/addrman.cpp b/src/addrman.cpp index 608be0bf151..43e7b6a32ce 100644 --- a/src/addrman.cpp +++ b/src/addrman.cpp @@ -253,7 +253,7 @@ void AddrManImpl::Unserialize(Stream& s_) throw InvalidAddrManVersionError(strprintf( "Unsupported format of addrman database: %u. It is compatible with formats >=%u, " "but the maximum supported by this version of %s is %u.", - uint8_t{format}, lowest_compatible, PACKAGE_NAME, uint8_t{FILE_FORMAT})); + uint8_t{format}, lowest_compatible, CLIENT_NAME, uint8_t{FILE_FORMAT})); } s >> nKey; diff --git a/src/bitcoin-cli-res.rc b/src/bitcoin-cli-res.rc index d9e5dcf7fd2..e0d4ee5f3c4 100644 --- a/src/bitcoin-cli-res.rc +++ b/src/bitcoin-cli-res.rc @@ -15,14 +15,14 @@ BEGIN BLOCK "040904E4" // U.S. English - multilingual (hex) BEGIN VALUE "CompanyName", "Bitcoin" - VALUE "FileDescription", "bitcoin-cli (JSON-RPC client for " PACKAGE_NAME ")" - VALUE "FileVersion", PACKAGE_VERSION + VALUE "FileDescription", "bitcoin-cli (JSON-RPC client for " CLIENT_NAME ")" + VALUE "FileVersion", CLIENT_VERSION_STRING VALUE "InternalName", "bitcoin-cli" VALUE "LegalCopyright", COPYRIGHT_STR VALUE "LegalTrademarks1", "Distributed under the MIT software license, see the accompanying file COPYING or http://www.opensource.org/licenses/mit-license.php." VALUE "OriginalFilename", "bitcoin-cli.exe" VALUE "ProductName", "bitcoin-cli" - VALUE "ProductVersion", PACKAGE_VERSION + VALUE "ProductVersion", CLIENT_VERSION_STRING END END diff --git a/src/bitcoin-cli.cpp b/src/bitcoin-cli.cpp index 38fd740b71d..8a4c1746161 100644 --- a/src/bitcoin-cli.cpp +++ b/src/bitcoin-cli.cpp @@ -145,14 +145,14 @@ static int AppInitRPC(int argc, char* argv[]) return EXIT_FAILURE; } if (argc < 2 || HelpRequested(gArgs) || gArgs.IsArgSet("-version")) { - std::string strUsage = PACKAGE_NAME " RPC client version " + FormatFullVersion() + "\n"; + std::string strUsage = CLIENT_NAME " RPC client version " + FormatFullVersion() + "\n"; if (gArgs.IsArgSet("-version")) { strUsage += FormatParagraph(LicenseInfo()); } else { strUsage += "\n" - "Usage: bitcoin-cli [options] [params] Send command to " PACKAGE_NAME "\n" - "or: bitcoin-cli [options] -named [name=value]... Send command to " PACKAGE_NAME " (with named arguments)\n" + "Usage: bitcoin-cli [options] [params] Send command to " CLIENT_NAME "\n" + "or: bitcoin-cli [options] -named [name=value]... Send command to " CLIENT_NAME " (with named arguments)\n" "or: bitcoin-cli [options] help List commands\n" "or: bitcoin-cli [options] help Get help for a command\n"; strUsage += "\n" + gArgs.GetHelpMessage(); @@ -535,7 +535,7 @@ class NetinfoRequestHandler : public BaseRequestHandler } // Generate report header. - std::string result{strprintf("%s client %s%s - server %i%s\n\n", PACKAGE_NAME, FormatFullVersion(), ChainToString(), networkinfo["protocolversion"].getInt(), networkinfo["subversion"].get_str())}; + std::string result{strprintf("%s client %s%s - server %i%s\n\n", CLIENT_NAME, FormatFullVersion(), ChainToString(), networkinfo["protocolversion"].getInt(), networkinfo["subversion"].get_str())}; // Report detailed peer connections list sorted by direction and minimum ping time. if (DetailsRequested() && !m_peers.empty()) { diff --git a/src/bitcoin-tx-res.rc b/src/bitcoin-tx-res.rc index 46e4fc92748..d5d7e3b7ca2 100644 --- a/src/bitcoin-tx-res.rc +++ b/src/bitcoin-tx-res.rc @@ -16,13 +16,13 @@ BEGIN BEGIN VALUE "CompanyName", "Bitcoin" VALUE "FileDescription", "bitcoin-tx (CLI Bitcoin transaction editor utility)" - VALUE "FileVersion", PACKAGE_VERSION + VALUE "FileVersion", CLIENT_VERSION_STRING VALUE "InternalName", "bitcoin-tx" VALUE "LegalCopyright", COPYRIGHT_STR VALUE "LegalTrademarks1", "Distributed under the MIT software license, see the accompanying file COPYING or http://www.opensource.org/licenses/mit-license.php." VALUE "OriginalFilename", "bitcoin-tx.exe" VALUE "ProductName", "bitcoin-tx" - VALUE "ProductVersion", PACKAGE_VERSION + VALUE "ProductVersion", CLIENT_VERSION_STRING END END diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp index b3329afba47..1aff914792b 100644 --- a/src/bitcoin-tx.cpp +++ b/src/bitcoin-tx.cpp @@ -107,7 +107,7 @@ static int AppInitRawTx(int argc, char* argv[]) if (argc < 2 || HelpRequested(gArgs) || gArgs.IsArgSet("-version")) { // First part of help message is specific to this utility - std::string strUsage = PACKAGE_NAME " bitcoin-tx utility version " + FormatFullVersion() + "\n"; + std::string strUsage = CLIENT_NAME " bitcoin-tx utility version " + FormatFullVersion() + "\n"; if (gArgs.IsArgSet("-version")) { strUsage += FormatParagraph(LicenseInfo()); diff --git a/src/bitcoin-util-res.rc b/src/bitcoin-util-res.rc index 0de8c5befac..e121d17f233 100644 --- a/src/bitcoin-util-res.rc +++ b/src/bitcoin-util-res.rc @@ -16,13 +16,13 @@ BEGIN BEGIN VALUE "CompanyName", "Bitcoin" VALUE "FileDescription", "bitcoin-util (CLI Bitcoin utility)" - VALUE "FileVersion", PACKAGE_VERSION + VALUE "FileVersion", CLIENT_VERSION_STRING VALUE "InternalName", "bitcoin-util" VALUE "LegalCopyright", COPYRIGHT_STR VALUE "LegalTrademarks1", "Distributed under the MIT software license, see the accompanying file COPYING or http://www.opensource.org/licenses/mit-license.php." VALUE "OriginalFilename", "bitcoin-util.exe" VALUE "ProductName", "bitcoin-util" - VALUE "ProductVersion", PACKAGE_VERSION + VALUE "ProductVersion", CLIENT_VERSION_STRING END END diff --git a/src/bitcoin-util.cpp b/src/bitcoin-util.cpp index 46ba136d81f..657de544b30 100644 --- a/src/bitcoin-util.cpp +++ b/src/bitcoin-util.cpp @@ -52,7 +52,7 @@ static int AppInitUtil(ArgsManager& args, int argc, char* argv[]) if (HelpRequested(args) || args.IsArgSet("-version")) { // First part of help message is specific to this utility - std::string strUsage = PACKAGE_NAME " bitcoin-util utility version " + FormatFullVersion() + "\n"; + std::string strUsage = CLIENT_NAME " bitcoin-util utility version " + FormatFullVersion() + "\n"; if (args.IsArgSet("-version")) { strUsage += FormatParagraph(LicenseInfo()); diff --git a/src/bitcoin-wallet-res.rc b/src/bitcoin-wallet-res.rc index d86ffbd9f12..4c7895f48d1 100644 --- a/src/bitcoin-wallet-res.rc +++ b/src/bitcoin-wallet-res.rc @@ -15,14 +15,14 @@ BEGIN BLOCK "040904E4" // U.S. English - multilingual (hex) BEGIN VALUE "CompanyName", "Bitcoin" - VALUE "FileDescription", "bitcoin-wallet (CLI tool for " PACKAGE_NAME " wallets)" - VALUE "FileVersion", PACKAGE_VERSION + VALUE "FileDescription", "bitcoin-wallet (CLI tool for " CLIENT_NAME " wallets)" + VALUE "FileVersion", CLIENT_VERSION_STRING VALUE "InternalName", "bitcoin-wallet" VALUE "LegalCopyright", COPYRIGHT_STR VALUE "LegalTrademarks1", "Distributed under the MIT software license, see the accompanying file COPYING or http://www.opensource.org/licenses/mit-license.php." VALUE "OriginalFilename", "bitcoin-wallet.exe" VALUE "ProductName", "bitcoin-wallet" - VALUE "ProductVersion", PACKAGE_VERSION + VALUE "ProductVersion", CLIENT_VERSION_STRING END END diff --git a/src/bitcoin-wallet.cpp b/src/bitcoin-wallet.cpp index 00f39be794a..c469fbda76b 100644 --- a/src/bitcoin-wallet.cpp +++ b/src/bitcoin-wallet.cpp @@ -61,13 +61,13 @@ static std::optional WalletAppInit(ArgsManager& args, int argc, char* argv[ } const bool missing_args{argc < 2}; if (missing_args || HelpRequested(args) || args.IsArgSet("-version")) { - std::string strUsage = strprintf("%s bitcoin-wallet version", PACKAGE_NAME) + " " + FormatFullVersion() + "\n"; + std::string strUsage = strprintf("%s bitcoin-wallet version", CLIENT_NAME) + " " + FormatFullVersion() + "\n"; if (args.IsArgSet("-version")) { strUsage += FormatParagraph(LicenseInfo()); } else { strUsage += "\n" - "bitcoin-wallet is an offline tool for creating and interacting with " PACKAGE_NAME " wallet files.\n" + "bitcoin-wallet is an offline tool for creating and interacting with " CLIENT_NAME " wallet files.\n" "By default bitcoin-wallet will act on wallets in the default mainnet wallet directory in the datadir.\n" "To change the target wallet, use the -datadir, -wallet and -regtest/-signet/-testnet/-testnet4 arguments.\n\n" "Usage:\n" diff --git a/src/bitcoind-res.rc b/src/bitcoind-res.rc index 353761dfa7e..4d689d7e16a 100644 --- a/src/bitcoind-res.rc +++ b/src/bitcoind-res.rc @@ -16,13 +16,13 @@ BEGIN BEGIN VALUE "CompanyName", "Bitcoin" VALUE "FileDescription", "bitcoind (Bitcoin node with a JSON-RPC server)" - VALUE "FileVersion", PACKAGE_VERSION + VALUE "FileVersion", CLIENT_VERSION_STRING VALUE "InternalName", "bitcoind" VALUE "LegalCopyright", COPYRIGHT_STR VALUE "LegalTrademarks1", "Distributed under the MIT software license, see the accompanying file COPYING or http://www.opensource.org/licenses/mit-license.php." VALUE "OriginalFilename", "bitcoind.exe" VALUE "ProductName", "bitcoind" - VALUE "ProductVersion", PACKAGE_VERSION + VALUE "ProductVersion", CLIENT_VERSION_STRING END END diff --git a/src/bitcoind.cpp b/src/bitcoind.cpp index 192676a10b2..e9d78f28883 100644 --- a/src/bitcoind.cpp +++ b/src/bitcoind.cpp @@ -136,12 +136,12 @@ static bool ProcessInitCommands(ArgsManager& args) { // Process help and version before taking care about datadir if (HelpRequested(args) || args.IsArgSet("-version")) { - std::string strUsage = PACKAGE_NAME " version " + FormatFullVersion() + "\n"; + std::string strUsage = CLIENT_NAME " version " + FormatFullVersion() + "\n"; if (args.IsArgSet("-version")) { strUsage += FormatParagraph(LicenseInfo()); } else { - strUsage += "\nUsage: bitcoind [options] Start " PACKAGE_NAME "\n" + strUsage += "\nUsage: bitcoind [options] Start " CLIENT_NAME "\n" "\n"; strUsage += args.GetHelpMessage(); } @@ -195,7 +195,7 @@ static bool AppInit(NodeContext& node) if (args.GetBoolArg("-daemon", DEFAULT_DAEMON) || args.GetBoolArg("-daemonwait", DEFAULT_DAEMONWAIT)) { #if HAVE_DECL_FORK - tfm::format(std::cout, PACKAGE_NAME " starting\n"); + tfm::format(std::cout, CLIENT_NAME " starting\n"); // Daemonize switch (fork_daemon(1, 0, daemon_ep)) { // don't chdir (1), do close FDs (0) diff --git a/src/clientversion.cpp b/src/clientversion.cpp index 7cdbda7de21..6fa3c700ee7 100644 --- a/src/clientversion.cpp +++ b/src/clientversion.cpp @@ -36,7 +36,7 @@ const std::string UA_NAME("Satoshi"); #define BUILD_DESC BUILD_GIT_TAG #define BUILD_SUFFIX "" #else - #define BUILD_DESC "v" PACKAGE_VERSION + #define BUILD_DESC "v" CLIENT_VERSION_STRING #if CLIENT_VERSION_IS_RELEASE #define BUILD_SUFFIX "" #elif defined(BUILD_GIT_COMMIT) @@ -88,7 +88,7 @@ std::string LicenseInfo() return CopyrightHolders(strprintf(_("Copyright (C) %i-%i").translated, 2009, COPYRIGHT_YEAR) + " ") + "\n" + "\n" + strprintf(_("Please contribute if you find %s useful. " - "Visit %s for further information about the software.").translated, PACKAGE_NAME, "<" PACKAGE_URL ">") + + "Visit %s for further information about the software.").translated, CLIENT_NAME, "<" CLIENT_URL ">") + "\n" + strprintf(_("The source code is available from %s.").translated, URL_SOURCE_CODE) + "\n" + diff --git a/src/common/settings.cpp b/src/common/settings.cpp index 0b11e246c66..046afca15d7 100644 --- a/src/common/settings.cpp +++ b/src/common/settings.cpp @@ -127,7 +127,7 @@ bool WriteSettings(const fs::path& path, SettingsValue out(SettingsValue::VOBJ); // Add auto-generated warning comment out.pushKV(SETTINGS_WARN_MSG_KEY, strprintf("This file is automatically generated and updated by %s. Please do not edit this file while the node " - "is running, as any changes might be ignored or overwritten.", PACKAGE_NAME)); + "is running, as any changes might be ignored or overwritten.", CLIENT_NAME)); // Push settings values for (const auto& value : values) { out.pushKVEnd(value.first, value.second); diff --git a/src/init.cpp b/src/init.cpp index 74a69e324ac..55e01e090b5 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -1079,7 +1079,7 @@ static bool LockDataDirectory(bool probeOnly) case util::LockResult::ErrorWrite: return InitError(strprintf(_("Cannot write to data directory '%s'; check permissions."), fs::PathToString(datadir))); case util::LockResult::ErrorLock: - return InitError(strprintf(_("Cannot obtain a lock on data directory %s. %s is probably already running."), fs::PathToString(datadir), PACKAGE_NAME)); + return InitError(strprintf(_("Cannot obtain a lock on data directory %s. %s is probably already running."), fs::PathToString(datadir), CLIENT_NAME)); case util::LockResult::Success: return true; } // no default case, so the compiler can warn about missing cases assert(false); @@ -1091,11 +1091,11 @@ bool AppInitSanityChecks(const kernel::Context& kernel) auto result{kernel::SanityChecks(kernel)}; if (!result) { InitError(util::ErrorString(result)); - return InitError(strprintf(_("Initialization sanity check failed. %s is shutting down."), PACKAGE_NAME)); + return InitError(strprintf(_("Initialization sanity check failed. %s is shutting down."), CLIENT_NAME)); } if (!ECC_InitSanityCheck()) { - return InitError(strprintf(_("Elliptic curve cryptography sanity check failure. %s is shutting down."), PACKAGE_NAME)); + return InitError(strprintf(_("Elliptic curve cryptography sanity check failure. %s is shutting down."), CLIENT_NAME)); } // Probe the data directory lock to give an early error message, if possible diff --git a/src/init/common.cpp b/src/init/common.cpp index dd8ca020d2e..8d0b008fb52 100644 --- a/src/init/common.cpp +++ b/src/init/common.cpp @@ -146,6 +146,6 @@ void LogPackageVersion() #else version_string += " (release build)"; #endif - LogPrintf(PACKAGE_NAME " version %s\n", version_string); + LogPrintf(CLIENT_NAME " version %s\n", version_string); } } // namespace init diff --git a/src/net.cpp b/src/net.cpp index 477240cdf2d..d76b39f75d5 100644 --- a/src/net.cpp +++ b/src/net.cpp @@ -3094,7 +3094,7 @@ bool CConnman::BindListenPort(const CService& addrBind, bilingual_str& strError, if (sock->Bind(reinterpret_cast(&sockaddr), len) == SOCKET_ERROR) { int nErr = WSAGetLastError(); if (nErr == WSAEADDRINUSE) - strError = strprintf(_("Unable to bind to %s on this computer. %s is probably already running."), addrBind.ToStringAddrPort(), PACKAGE_NAME); + strError = strprintf(_("Unable to bind to %s on this computer. %s is probably already running."), addrBind.ToStringAddrPort(), CLIENT_NAME); else strError = strprintf(_("Unable to bind to %s on this computer (bind returned error %s)"), addrBind.ToStringAddrPort(), NetworkErrorString(nErr)); LogPrintLevel(BCLog::NET, BCLog::Level::Error, "%s\n", strError.original); diff --git a/src/qt/bitcoin.cpp b/src/qt/bitcoin.cpp index c43cb778660..5c1ae895b1d 100644 --- a/src/qt/bitcoin.cpp +++ b/src/qt/bitcoin.cpp @@ -162,7 +162,7 @@ static void initTranslations(QTranslator &qtTranslatorBase, QTranslator &qtTrans static bool ErrorSettingsRead(const bilingual_str& error, const std::vector& details) { - QMessageBox messagebox(QMessageBox::Critical, PACKAGE_NAME, QString::fromStdString(strprintf("%s.", error.translated)), QMessageBox::Reset | QMessageBox::Abort); + QMessageBox messagebox(QMessageBox::Critical, CLIENT_NAME, QString::fromStdString(strprintf("%s.", error.translated)), QMessageBox::Reset | QMessageBox::Abort); /*: Explanatory text shown on startup when the settings file cannot be read. Prompts user to make a choice between resetting or aborting. */ messagebox.setInformativeText(QObject::tr("Do you want to reset settings to default values, or to abort without making changes?")); @@ -181,7 +181,7 @@ static bool ErrorSettingsRead(const bilingual_str& error, const std::vector& details) { - QMessageBox messagebox(QMessageBox::Critical, PACKAGE_NAME, QString::fromStdString(strprintf("%s.", error.translated)), QMessageBox::Ok); + QMessageBox messagebox(QMessageBox::Critical, CLIENT_NAME, QString::fromStdString(strprintf("%s.", error.translated)), QMessageBox::Ok); /*: Explanatory text shown on startup when the settings file could not be written. Prompts user to check that we have the ability to write to the file. Explains that the user has the option of running without a settings file.*/ @@ -260,7 +260,7 @@ bool BitcoinApplication::createOptionsModel(bool resetSettings) error.translated += tr("Settings file %1 might be corrupt or invalid.").arg(QString::fromStdString(quoted_path)).toStdString(); } InitError(error); - QMessageBox::critical(nullptr, PACKAGE_NAME, QString::fromStdString(error.translated)); + QMessageBox::critical(nullptr, CLIENT_NAME, QString::fromStdString(error.translated)); return false; } return true; @@ -442,8 +442,8 @@ void BitcoinApplication::handleRunawayException(const QString &message) { QMessageBox::critical( nullptr, tr("Runaway exception"), - tr("A fatal error occurred. %1 can no longer continue safely and will quit.").arg(PACKAGE_NAME) + - QLatin1String("

") + GUIUtil::MakeHtmlLink(message, PACKAGE_BUGREPORT)); + tr("A fatal error occurred. %1 can no longer continue safely and will quit.").arg(CLIENT_NAME) + + QLatin1String("

") + GUIUtil::MakeHtmlLink(message, CLIENT_BUGREPORT)); ::exit(EXIT_FAILURE); } @@ -453,8 +453,8 @@ void BitcoinApplication::handleNonFatalException(const QString& message) QMessageBox::warning( nullptr, tr("Internal error"), tr("An internal error occurred. %1 will attempt to continue safely. This is " - "an unexpected bug which can be reported as described below.").arg(PACKAGE_NAME) + - QLatin1String("

") + GUIUtil::MakeHtmlLink(message, PACKAGE_BUGREPORT)); + "an unexpected bug which can be reported as described below.").arg(CLIENT_NAME) + + QLatin1String("

") + GUIUtil::MakeHtmlLink(message, CLIENT_BUGREPORT)); } WId BitcoinApplication::getMainWinId() const @@ -531,7 +531,7 @@ int GuiMain(int argc, char* argv[]) if (!gArgs.ParseParameters(argc, argv, error)) { InitError(strprintf(Untranslated("Error parsing command line arguments: %s"), error)); // Create a message box, because the gui has neither been created nor has subscribed to core signals - QMessageBox::critical(nullptr, PACKAGE_NAME, + QMessageBox::critical(nullptr, CLIENT_NAME, // message cannot be translated because translations have not been initialized QString::fromStdString("Error parsing command line arguments: %1.").arg(QString::fromStdString(error))); return EXIT_FAILURE; @@ -551,14 +551,14 @@ int GuiMain(int argc, char* argv[]) #endif if (payment_server_token_seen && arg.startsWith("-")) { InitError(Untranslated(strprintf("Options ('%s') cannot follow a BIP-21 payment URI", argv[i]))); - QMessageBox::critical(nullptr, PACKAGE_NAME, + QMessageBox::critical(nullptr, CLIENT_NAME, // message cannot be translated because translations have not been initialized QString::fromStdString("Options ('%1') cannot follow a BIP-21 payment URI").arg(QString::fromStdString(argv[i]))); return EXIT_FAILURE; } if (invalid_token) { InitError(Untranslated(strprintf("Command line contains unexpected token '%s', see bitcoin-qt -h for a list of options.", argv[i]))); - QMessageBox::critical(nullptr, PACKAGE_NAME, + QMessageBox::critical(nullptr, CLIENT_NAME, // message cannot be translated because translations have not been initialized QString::fromStdString("Command line contains unexpected token '%1', see bitcoin-qt -h for a list of options.").arg(QString::fromStdString(argv[i]))); return EXIT_FAILURE; @@ -613,7 +613,7 @@ int GuiMain(int argc, char* argv[]) } else if (error->status != common::ConfigStatus::ABORTED) { // Show a generic message in other cases, and no additional error // message in the case of a read error if the user decided to abort. - QMessageBox::critical(nullptr, PACKAGE_NAME, QObject::tr("Error: %1").arg(QString::fromStdString(error->message.translated))); + QMessageBox::critical(nullptr, CLIENT_NAME, QObject::tr("Error: %1").arg(QString::fromStdString(error->message.translated))); } return EXIT_FAILURE; } @@ -686,7 +686,7 @@ int GuiMain(int argc, char* argv[]) if (app.baseInitialize()) { app.requestInitialize(); #if defined(Q_OS_WIN) - WinShutdownMonitor::registerShutdownBlockReason(QObject::tr("%1 didn't yet exit safely…").arg(PACKAGE_NAME), (HWND)app.getMainWinId()); + WinShutdownMonitor::registerShutdownBlockReason(QObject::tr("%1 didn't yet exit safely…").arg(CLIENT_NAME), (HWND)app.getMainWinId()); #endif app.exec(); } else { diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp index 6d7e183e985..f899a524f45 100644 --- a/src/qt/bitcoingui.cpp +++ b/src/qt/bitcoingui.cpp @@ -294,15 +294,15 @@ void BitcoinGUI::createActions() quitAction->setStatusTip(tr("Quit application")); quitAction->setShortcut(QKeySequence(tr("Ctrl+Q"))); quitAction->setMenuRole(QAction::QuitRole); - aboutAction = new QAction(tr("&About %1").arg(PACKAGE_NAME), this); - aboutAction->setStatusTip(tr("Show information about %1").arg(PACKAGE_NAME)); + aboutAction = new QAction(tr("&About %1").arg(CLIENT_NAME), this); + aboutAction->setStatusTip(tr("Show information about %1").arg(CLIENT_NAME)); aboutAction->setMenuRole(QAction::AboutRole); aboutAction->setEnabled(false); aboutQtAction = new QAction(tr("About &Qt"), this); aboutQtAction->setStatusTip(tr("Show information about Qt")); aboutQtAction->setMenuRole(QAction::AboutQtRole); optionsAction = new QAction(tr("&Options…"), this); - optionsAction->setStatusTip(tr("Modify configuration options for %1").arg(PACKAGE_NAME)); + optionsAction->setStatusTip(tr("Modify configuration options for %1").arg(CLIENT_NAME)); optionsAction->setMenuRole(QAction::PreferencesRole); optionsAction->setEnabled(false); @@ -364,7 +364,7 @@ void BitcoinGUI::createActions() showHelpMessageAction = new QAction(tr("&Command-line options"), this); showHelpMessageAction->setMenuRole(QAction::NoRole); - showHelpMessageAction->setStatusTip(tr("Show the %1 help message to get a list with possible Bitcoin command-line options").arg(PACKAGE_NAME)); + showHelpMessageAction->setStatusTip(tr("Show the %1 help message to get a list with possible Bitcoin command-line options").arg(CLIENT_NAME)); m_mask_values_action = new QAction(tr("&Mask values"), this); m_mask_values_action->setShortcut(QKeySequence(Qt::CTRL | Qt::SHIFT | Qt::Key_M)); @@ -837,7 +837,7 @@ void BitcoinGUI::createTrayIcon() #ifndef Q_OS_MACOS if (QSystemTrayIcon::isSystemTrayAvailable()) { trayIcon = new QSystemTrayIcon(m_network_style->getTrayAndWindowIcon(), this); - QString toolTip = tr("%1 client").arg(PACKAGE_NAME) + " " + m_network_style->getTitleAddText(); + QString toolTip = tr("%1 client").arg(CLIENT_NAME) + " " + m_network_style->getTitleAddText(); trayIcon->setToolTip(toolTip); } #endif @@ -1230,7 +1230,7 @@ void BitcoinGUI::createWallet() void BitcoinGUI::message(const QString& title, QString message, unsigned int style, bool* ret, const QString& detailed_message) { // Default title. On macOS, the window title is ignored (as required by the macOS Guidelines). - QString strTitle{PACKAGE_NAME}; + QString strTitle{CLIENT_NAME}; // Default to information icon int nMBoxIcon = QMessageBox::Information; int nNotifyIcon = Notificator::Information; @@ -1489,7 +1489,7 @@ void BitcoinGUI::updateProxyIcon() void BitcoinGUI::updateWindowTitle() { - QString window_title = PACKAGE_NAME; + QString window_title = CLIENT_NAME; #ifdef ENABLE_WALLET if (walletFrame) { WalletModel* const wallet_model = walletFrame->currentWalletModel(); diff --git a/src/qt/intro.cpp b/src/qt/intro.cpp index bc770b71aa5..eeee13b2245 100644 --- a/src/qt/intro.cpp +++ b/src/qt/intro.cpp @@ -127,16 +127,16 @@ Intro::Intro(QWidget *parent, int64_t blockchain_size_gb, int64_t chain_state_si m_prune_target_gb{GetPruneTargetGB()} { ui->setupUi(this); - ui->welcomeLabel->setText(ui->welcomeLabel->text().arg(PACKAGE_NAME)); - ui->storageLabel->setText(ui->storageLabel->text().arg(PACKAGE_NAME)); + ui->welcomeLabel->setText(ui->welcomeLabel->text().arg(CLIENT_NAME)); + ui->storageLabel->setText(ui->storageLabel->text().arg(CLIENT_NAME)); ui->lblExplanation1->setText(ui->lblExplanation1->text() - .arg(PACKAGE_NAME) + .arg(CLIENT_NAME) .arg(m_blockchain_size_gb) .arg(2009) .arg(tr("Bitcoin")) ); - ui->lblExplanation2->setText(ui->lblExplanation2->text().arg(PACKAGE_NAME)); + ui->lblExplanation2->setText(ui->lblExplanation2->text().arg(CLIENT_NAME)); const int min_prune_target_GB = std::ceil(MIN_DISK_SPACE_FOR_BLOCK_FILES / 1e9); ui->pruneGB->setRange(min_prune_target_GB, std::numeric_limits::max()); @@ -246,7 +246,7 @@ bool Intro::showIfNeeded(bool& did_show_intro, int64_t& prune_MiB) } break; } catch (const fs::filesystem_error&) { - QMessageBox::critical(nullptr, PACKAGE_NAME, + QMessageBox::critical(nullptr, CLIENT_NAME, tr("Error: Specified data directory \"%1\" cannot be created.").arg(dataDir)); /* fall through, back to choosing screen */ } @@ -389,7 +389,7 @@ void Intro::UpdatePruneLabels(bool prune_checked) //: Explanatory text on the capability of the current prune target. tr("(sufficient to restore backups %n day(s) old)", "", expected_backup_days)); ui->sizeWarningLabel->setText( - tr("%1 will download and store a copy of the Bitcoin block chain.").arg(PACKAGE_NAME) + " " + + tr("%1 will download and store a copy of the Bitcoin block chain.").arg(CLIENT_NAME) + " " + storageRequiresMsg.arg(m_required_space_gb) + " " + tr("The wallet will also be stored in this directory.") ); diff --git a/src/qt/modaloverlay.cpp b/src/qt/modaloverlay.cpp index 522ecfd8017..e752628d989 100644 --- a/src/qt/modaloverlay.cpp +++ b/src/qt/modaloverlay.cpp @@ -31,7 +31,7 @@ ModalOverlay::ModalOverlay(bool enable_wallet, QWidget* parent) setVisible(false); if (!enable_wallet) { ui->infoText->setVisible(false); - ui->infoTextStrong->setText(tr("%1 is currently syncing. It will download headers and blocks from peers and validate them until reaching the tip of the block chain.").arg(PACKAGE_NAME)); + ui->infoTextStrong->setText(tr("%1 is currently syncing. It will download headers and blocks from peers and validate them until reaching the tip of the block chain.").arg(CLIENT_NAME)); } m_animation.setTargetObject(this); diff --git a/src/qt/optionsdialog.cpp b/src/qt/optionsdialog.cpp index f821b1ceb2e..f86b5229db0 100644 --- a/src/qt/optionsdialog.cpp +++ b/src/qt/optionsdialog.cpp @@ -139,7 +139,7 @@ OptionsDialog::OptionsDialog(QWidget* parent, bool enableWallet) } #ifdef ENABLE_EXTERNAL_SIGNER - ui->externalSignerPath->setToolTip(ui->externalSignerPath->toolTip().arg(PACKAGE_NAME)); + ui->externalSignerPath->setToolTip(ui->externalSignerPath->toolTip().arg(CLIENT_NAME)); #else //: "External signing" means using devices such as hardware wallets. ui->externalSignerPath->setToolTip(tr("Compiled without external signing support (required for external signing)")); @@ -148,12 +148,12 @@ OptionsDialog::OptionsDialog(QWidget* parent, bool enableWallet) /* Display elements init */ QDir translations(":translations"); - ui->bitcoinAtStartup->setToolTip(ui->bitcoinAtStartup->toolTip().arg(PACKAGE_NAME)); - ui->bitcoinAtStartup->setText(ui->bitcoinAtStartup->text().arg(PACKAGE_NAME)); + ui->bitcoinAtStartup->setToolTip(ui->bitcoinAtStartup->toolTip().arg(CLIENT_NAME)); + ui->bitcoinAtStartup->setText(ui->bitcoinAtStartup->text().arg(CLIENT_NAME)); - ui->openBitcoinConfButton->setToolTip(ui->openBitcoinConfButton->toolTip().arg(PACKAGE_NAME)); + ui->openBitcoinConfButton->setToolTip(ui->openBitcoinConfButton->toolTip().arg(CLIENT_NAME)); - ui->lang->setToolTip(ui->lang->toolTip().arg(PACKAGE_NAME)); + ui->lang->setToolTip(ui->lang->toolTip().arg(CLIENT_NAME)); ui->lang->addItem(QString("(") + tr("default") + QString(")"), QVariant("")); for (const QString &langStr : translations.entryList()) { diff --git a/src/qt/res/bitcoin-qt-res.rc b/src/qt/res/bitcoin-qt-res.rc index d84744f91e7..9a379f06d40 100644 --- a/src/qt/res/bitcoin-qt-res.rc +++ b/src/qt/res/bitcoin-qt-res.rc @@ -22,13 +22,13 @@ BEGIN BLOCK "040904E4" // U.S. English - multilingual (hex) BEGIN VALUE "CompanyName", "Bitcoin" - VALUE "FileDescription", PACKAGE_NAME " (GUI node for Bitcoin)" + VALUE "FileDescription", CLIENT_NAME " (GUI node for Bitcoin)" VALUE "FileVersion", VER_FILEVERSION_STR VALUE "InternalName", "bitcoin-qt" VALUE "LegalCopyright", COPYRIGHT_STR VALUE "LegalTrademarks1", "Distributed under the MIT software license, see the accompanying file COPYING or http://www.opensource.org/licenses/mit-license.php." VALUE "OriginalFilename", "bitcoin-qt.exe" - VALUE "ProductName", PACKAGE_NAME + VALUE "ProductName", CLIENT_NAME VALUE "ProductVersion", VER_PRODUCTVERSION_STR END END diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp index 018c22a4a81..9d7c17ac911 100644 --- a/src/qt/rpcconsole.cpp +++ b/src/qt/rpcconsole.cpp @@ -536,7 +536,7 @@ RPCConsole::RPCConsole(interfaces::Node& node, const PlatformStyle *_platformSty ui->peerHighBandwidthLabel->setToolTip(ui->peerHighBandwidthLabel->toolTip().arg(hb_list)); ui->dataDir->setToolTip(ui->dataDir->toolTip().arg(QString(nonbreaking_hyphen) + "datadir")); ui->blocksDir->setToolTip(ui->blocksDir->toolTip().arg(QString(nonbreaking_hyphen) + "blocksdir")); - ui->openDebugLogfileButton->setToolTip(ui->openDebugLogfileButton->toolTip().arg(PACKAGE_NAME)); + ui->openDebugLogfileButton->setToolTip(ui->openDebugLogfileButton->toolTip().arg(CLIENT_NAME)); if (platformStyle->getImagesOnButtons()) { ui->openDebugLogfileButton->setIcon(platformStyle->SingleColorIcon(":/icons/export")); @@ -914,7 +914,7 @@ void RPCConsole::clear(bool keep_prompt) "%7WARNING: Scammers have been active, telling users to type" " commands here, stealing their wallet contents. Do not use this console" " without fully understanding the ramifications of a command.%8") - .arg(PACKAGE_NAME, + .arg(CLIENT_NAME, "" + ui->clearButton->shortcut().toString(QKeySequence::NativeText) + "", "" + ui->fontBiggerButton->shortcut().toString(QKeySequence::NativeText) + "", "" + ui->fontSmallerButton->shortcut().toString(QKeySequence::NativeText) + "", diff --git a/src/qt/sendcoinsdialog.cpp b/src/qt/sendcoinsdialog.cpp index 4019ca5e9d1..0ee1b359fa9 100644 --- a/src/qt/sendcoinsdialog.cpp +++ b/src/qt/sendcoinsdialog.cpp @@ -210,7 +210,7 @@ void SendCoinsDialog::setModel(WalletModel *_model) } } else if (model->wallet().privateKeysDisabled()) { ui->sendButton->setText(tr("Cr&eate Unsigned")); - ui->sendButton->setToolTip(tr("Creates a Partially Signed Bitcoin Transaction (PSBT) for use with e.g. an offline %1 wallet, or a PSBT-compatible hardware wallet.").arg(PACKAGE_NAME)); + ui->sendButton->setToolTip(tr("Creates a Partially Signed Bitcoin Transaction (PSBT) for use with e.g. an offline %1 wallet, or a PSBT-compatible hardware wallet.").arg(CLIENT_NAME)); } // set the smartfee-sliders default value (wallets default conf.target or last stored value) @@ -332,12 +332,12 @@ bool SendCoinsDialog::PrepareSendText(QString& question_string, QString& informa /*: Text to inform a user attempting to create a transaction of their current options. At this stage, a user can only create a PSBT. This string is displayed when private keys are disabled and an external signer is not available. */ - question_string.append(tr("Please, review your transaction proposal. This will produce a Partially Signed Bitcoin Transaction (PSBT) which you can save or copy and then sign with e.g. an offline %1 wallet, or a PSBT-compatible hardware wallet.").arg(PACKAGE_NAME)); + question_string.append(tr("Please, review your transaction proposal. This will produce a Partially Signed Bitcoin Transaction (PSBT) which you can save or copy and then sign with e.g. an offline %1 wallet, or a PSBT-compatible hardware wallet.").arg(CLIENT_NAME)); } else if (model->getOptionsModel()->getEnablePSBTControls()) { /*: Text to inform a user attempting to create a transaction of their current options. At this stage, a user can send their transaction or create a PSBT. This string is displayed when both private keys and PSBT controls are enabled. */ - question_string.append(tr("Please, review your transaction. You can create and send this transaction or create a Partially Signed Bitcoin Transaction (PSBT), which you can save or copy and then sign with, e.g., an offline %1 wallet, or a PSBT-compatible hardware wallet.").arg(PACKAGE_NAME)); + question_string.append(tr("Please, review your transaction. You can create and send this transaction or create a Partially Signed Bitcoin Transaction (PSBT), which you can save or copy and then sign with, e.g., an offline %1 wallet, or a PSBT-compatible hardware wallet.").arg(CLIENT_NAME)); } else { /*: Text to prompt a user to review the details of the transaction they are attempting to send. */ question_string.append(tr("Please, review your transaction.")); diff --git a/src/qt/signverifymessagedialog.cpp b/src/qt/signverifymessagedialog.cpp index 0b1d3c6c3a7..e46fe061624 100644 --- a/src/qt/signverifymessagedialog.cpp +++ b/src/qt/signverifymessagedialog.cpp @@ -124,7 +124,7 @@ void SignVerifyMessageDialog::on_signMessageButton_SM_clicked() if (!pkhash) { ui->addressIn_SM->setValid(false); ui->statusLabel_SM->setStyleSheet("QLabel { color: red; }"); - ui->statusLabel_SM->setText(tr("The entered address does not refer to a legacy (P2PKH) key. Message signing for SegWit and other non-P2PKH address types is not supported in this version of %1. Please check the address and try again.").arg(PACKAGE_NAME)); + ui->statusLabel_SM->setText(tr("The entered address does not refer to a legacy (P2PKH) key. Message signing for SegWit and other non-P2PKH address types is not supported in this version of %1. Please check the address and try again.").arg(CLIENT_NAME)); return; } @@ -222,7 +222,7 @@ void SignVerifyMessageDialog::on_verifyMessageButton_VM_clicked() return; case MessageVerificationResult::ERR_ADDRESS_NO_KEY: ui->addressIn_VM->setValid(false); - ui->statusLabel_VM->setText(tr("The entered address does not refer to a legacy (P2PKH) key. Message signing for SegWit and other non-P2PKH address types is not supported in this version of %1. Please check the address and try again.").arg(PACKAGE_NAME)); + ui->statusLabel_VM->setText(tr("The entered address does not refer to a legacy (P2PKH) key. Message signing for SegWit and other non-P2PKH address types is not supported in this version of %1. Please check the address and try again.").arg(CLIENT_NAME)); return; case MessageVerificationResult::ERR_MALFORMED_SIGNATURE: ui->signatureIn_VM->setValid(false); diff --git a/src/qt/splashscreen.cpp b/src/qt/splashscreen.cpp index e194b5fd32c..ccaa201811f 100644 --- a/src/qt/splashscreen.cpp +++ b/src/qt/splashscreen.cpp @@ -39,7 +39,7 @@ SplashScreen::SplashScreen(const NetworkStyle* networkStyle) devicePixelRatio = static_cast(QCoreApplication::instance())->devicePixelRatio(); // define text to place - QString titleText = PACKAGE_NAME; + QString titleText = CLIENT_NAME; QString versionText = QString("Version %1").arg(QString::fromStdString(FormatFullVersion())); QString copyrightText = QString::fromUtf8(CopyrightHolders(strprintf("\xc2\xA9 %u-%u ", 2009, COPYRIGHT_YEAR)).c_str()); const QString& titleAddText = networkStyle->getTitleAddText(); diff --git a/src/qt/test/optiontests.cpp b/src/qt/test/optiontests.cpp index 4d25d4994d2..f8a1da84121 100644 --- a/src/qt/test/optiontests.cpp +++ b/src/qt/test/optiontests.cpp @@ -73,7 +73,7 @@ void OptionTests::migrateSettings() std::ifstream file(gArgs.GetDataDirNet() / "settings.json"); std::string default_warning = strprintf("This file is automatically generated and updated by %s. Please do not edit this file while the node " "is running, as any changes might be ignored or overwritten.", - PACKAGE_NAME); + CLIENT_NAME); QCOMPARE(std::string(std::istreambuf_iterator(file), std::istreambuf_iterator()).c_str(), "{\n" " \"_warning_\": \""+ default_warning+"\",\n" " \"dbcache\": \"600\",\n" diff --git a/src/qt/utilitydialog.cpp b/src/qt/utilitydialog.cpp index 29b7f5c4018..4e4fb029726 100644 --- a/src/qt/utilitydialog.cpp +++ b/src/qt/utilitydialog.cpp @@ -33,11 +33,11 @@ HelpMessageDialog::HelpMessageDialog(QWidget *parent, bool about) : { ui->setupUi(this); - QString version = QString{PACKAGE_NAME} + " " + tr("version") + " " + QString::fromStdString(FormatFullVersion()); + QString version = QString{CLIENT_NAME} + " " + tr("version") + " " + QString::fromStdString(FormatFullVersion()); if (about) { - setWindowTitle(tr("About %1").arg(PACKAGE_NAME)); + setWindowTitle(tr("About %1").arg(CLIENT_NAME)); std::string licenseInfo = LicenseInfo(); /// HTML-format the license message from the core @@ -141,7 +141,7 @@ ShutdownWindow::ShutdownWindow(QWidget *parent, Qt::WindowFlags f): { QVBoxLayout *layout = new QVBoxLayout(); layout->addWidget(new QLabel( - tr("%1 is shutting down…").arg(PACKAGE_NAME) + "

" + + tr("%1 is shutting down…").arg(CLIENT_NAME) + "

" + tr("Do not shut down the computer until this window disappears."))); setLayout(layout); diff --git a/src/rest.cpp b/src/rest.cpp index 9b282dc484f..3e4b8b37c6c 100644 --- a/src/rest.cpp +++ b/src/rest.cpp @@ -90,7 +90,7 @@ static NodeContext* GetNodeContext(const std::any& context, HTTPRequest* req) strprintf("%s:%d (%s)\n" "Internal bug detected: Node context not found!\n" "You may report this issue here: %s\n", - __FILE__, __LINE__, __func__, PACKAGE_BUGREPORT)); + __FILE__, __LINE__, __func__, CLIENT_BUGREPORT)); return nullptr; } return node_context; @@ -128,7 +128,7 @@ static ChainstateManager* GetChainman(const std::any& context, HTTPRequest* req) strprintf("%s:%d (%s)\n" "Internal bug detected: Chainman disabled or instance not found!\n" "You may report this issue here: %s\n", - __FILE__, __LINE__, __func__, PACKAGE_BUGREPORT)); + __FILE__, __LINE__, __func__, CLIENT_BUGREPORT)); return nullptr; } return node_context->chainman.get(); diff --git a/src/rpc/mining.cpp b/src/rpc/mining.cpp index 44605cbc890..c1af397872c 100644 --- a/src/rpc/mining.cpp +++ b/src/rpc/mining.cpp @@ -274,7 +274,7 @@ static RPCHelpMan generatetoaddress() RPCExamples{ "\nGenerate 11 blocks to myaddress\n" + HelpExampleCli("generatetoaddress", "11 \"myaddress\"") - + "If you are using the " PACKAGE_NAME " wallet, you can get a new address to send the newly generated bitcoin to with:\n" + + "If you are using the " CLIENT_NAME " wallet, you can get a new address to send the newly generated bitcoin to with:\n" + HelpExampleCli("getnewaddress", "") }, [&](const RPCHelpMan& self, const JSONRPCRequest& request) -> UniValue @@ -724,11 +724,11 @@ static RPCHelpMan getblocktemplate() if (!miner.isTestChain()) { const CConnman& connman = EnsureConnman(node); if (connman.GetNodeCount(ConnectionDirection::Both) == 0) { - throw JSONRPCError(RPC_CLIENT_NOT_CONNECTED, PACKAGE_NAME " is not connected!"); + throw JSONRPCError(RPC_CLIENT_NOT_CONNECTED, CLIENT_NAME " is not connected!"); } if (miner.isInitialBlockDownload()) { - throw JSONRPCError(RPC_CLIENT_IN_INITIAL_DOWNLOAD, PACKAGE_NAME " is in initial sync and waiting for blocks..."); + throw JSONRPCError(RPC_CLIENT_IN_INITIAL_DOWNLOAD, CLIENT_NAME " is in initial sync and waiting for blocks..."); } } diff --git a/src/rpc/server.cpp b/src/rpc/server.cpp index 01f2dc0c0ec..34f19df2564 100644 --- a/src/rpc/server.cpp +++ b/src/rpc/server.cpp @@ -154,12 +154,12 @@ static RPCHelpMan help() static RPCHelpMan stop() { - static const std::string RESULT{PACKAGE_NAME " stopping"}; + static const std::string RESULT{CLIENT_NAME " stopping"}; return RPCHelpMan{"stop", // Also accept the hidden 'wait' integer argument (milliseconds) // For instance, 'stop 1000' makes the call wait 1 second before returning // to the client (intended for testing) - "\nRequest a graceful shutdown of " PACKAGE_NAME ".", + "\nRequest a graceful shutdown of " CLIENT_NAME ".", { {"wait", RPCArg::Type::NUM, RPCArg::Optional::OMITTED, "how long to wait in ms", RPCArgOptions{.hidden=true}}, }, diff --git a/src/rpc/util.cpp b/src/rpc/util.cpp index d71d7d737b0..00072296cc8 100644 --- a/src/rpc/util.cpp +++ b/src/rpc/util.cpp @@ -696,8 +696,8 @@ UniValue RPCHelpMan::HandleRequest(const JSONRPCRequest& request) const throw std::runtime_error{ strprintf("Internal bug detected: RPC call \"%s\" returned incorrect type:\n%s\n%s %s\nPlease report this issue here: %s\n", m_name, explain, - PACKAGE_NAME, FormatFullVersion(), - PACKAGE_BUGREPORT)}; + CLIENT_NAME, FormatFullVersion(), + CLIENT_BUGREPORT)}; } } return ret; diff --git a/src/util/check.cpp b/src/util/check.cpp index 57ff78f7a08..098070d7518 100644 --- a/src/util/check.cpp +++ b/src/util/check.cpp @@ -21,7 +21,7 @@ std::string StrFormatInternalBug(std::string_view msg, std::string_view file, in return strprintf("Internal bug detected: %s\n%s:%d (%s)\n" "%s %s\n" "Please report this issue here: %s\n", - msg, file, line, func, PACKAGE_NAME, FormatFullVersion(), PACKAGE_BUGREPORT); + msg, file, line, func, CLIENT_NAME, FormatFullVersion(), CLIENT_BUGREPORT); } NonFatalCheckError::NonFatalCheckError(std::string_view msg, std::string_view file, int line, std::string_view func) diff --git a/src/validation.cpp b/src/validation.cpp index 0dd5aeffc28..226f344d92f 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -3453,7 +3453,7 @@ bool Chainstate::ActivateBestChain(BlockValidationState& state, std::shared_ptr< // chainstate past the snapshot base block. if (WITH_LOCK(::cs_main, return m_disabled)) { LogPrintf("m_disabled is set - this chainstate should not be in operation. " - "Please report this as a bug. %s\n", PACKAGE_BUGREPORT); + "Please report this as a bug. %s\n", CLIENT_BUGREPORT); return false; } @@ -3852,7 +3852,7 @@ void ChainstateManager::ReceivedBlockTransactions(const CBlock& block, CBlockInd if (!Assume(pindexNew->m_chain_tx_count == 0 || pindexNew->m_chain_tx_count == prev_tx_sum(*pindexNew) || pindexNew == GetSnapshotBaseBlock())) { LogWarning("Internal bug detected: block %d has unexpected m_chain_tx_count %i that should be %i (%s %s). Please report this issue here: %s\n", - pindexNew->nHeight, pindexNew->m_chain_tx_count, prev_tx_sum(*pindexNew), PACKAGE_NAME, FormatFullVersion(), PACKAGE_BUGREPORT); + pindexNew->nHeight, pindexNew->m_chain_tx_count, prev_tx_sum(*pindexNew), CLIENT_NAME, FormatFullVersion(), CLIENT_BUGREPORT); pindexNew->m_chain_tx_count = 0; } pindexNew->nFile = pos.nFile; @@ -3880,7 +3880,7 @@ void ChainstateManager::ReceivedBlockTransactions(const CBlock& block, CBlockInd // incorrect hardcoded AssumeutxoData::m_chain_tx_count value. if (!Assume(pindex->m_chain_tx_count == 0 || pindex->m_chain_tx_count == prev_tx_sum(*pindex))) { LogWarning("Internal bug detected: block %d has unexpected m_chain_tx_count %i that should be %i (%s %s). Please report this issue here: %s\n", - pindex->nHeight, pindex->m_chain_tx_count, prev_tx_sum(*pindex), PACKAGE_NAME, FormatFullVersion(), PACKAGE_BUGREPORT); + pindex->nHeight, pindex->m_chain_tx_count, prev_tx_sum(*pindex), CLIENT_NAME, FormatFullVersion(), CLIENT_BUGREPORT); } pindex->m_chain_tx_count = prev_tx_sum(*pindex); pindex->nSequenceId = nBlockSequenceId++; @@ -5564,7 +5564,7 @@ double GuessVerificationProgress(const ChainTxData& data, const CBlockIndex *pin if (!Assume(pindex->m_chain_tx_count > 0)) { LogWarning("Internal bug detected: block %d has unset m_chain_tx_count (%s %s). Please report this issue here: %s\n", - pindex->nHeight, PACKAGE_NAME, FormatFullVersion(), PACKAGE_BUGREPORT); + pindex->nHeight, CLIENT_NAME, FormatFullVersion(), CLIENT_BUGREPORT); return 0.0; } @@ -6083,7 +6083,7 @@ SnapshotCompletionResult ChainstateManager::MaybeCompleteSnapshotValidation() "Please report this incident to %s, including how you obtained the snapshot. " "The invalid snapshot chainstate will be left on disk in case it is " "helpful in diagnosing the issue that caused this error."), - PACKAGE_NAME, snapshot_tip_height, snapshot_base_height, snapshot_base_height, PACKAGE_BUGREPORT + CLIENT_NAME, snapshot_tip_height, snapshot_base_height, snapshot_base_height, CLIENT_BUGREPORT ); LogError("[snapshot] !!! %s\n", user_error.original); diff --git a/src/wallet/rpc/backup.cpp b/src/wallet/rpc/backup.cpp index 4ffc6f1e0dd..ea7c349d0b9 100644 --- a/src/wallet/rpc/backup.cpp +++ b/src/wallet/rpc/backup.cpp @@ -757,7 +757,7 @@ RPCHelpMan dumpwallet() std::sort(vKeyBirth.begin(), vKeyBirth.end()); // produce output - file << strprintf("# Wallet dump created by %s %s\n", PACKAGE_NAME, FormatFullVersion()); + file << strprintf("# Wallet dump created by %s %s\n", CLIENT_NAME, FormatFullVersion()); file << strprintf("# * Created on %s\n", FormatISO8601DateTime(GetTime())); file << strprintf("# * Best block at time of backup was %i (%s),\n", wallet.GetLastBlockHeight(), wallet.GetLastBlockHash().ToString()); file << strprintf("# mined on %s\n", FormatISO8601DateTime(block_time)); diff --git a/src/wallet/sqlite.cpp b/src/wallet/sqlite.cpp index ab082327def..a8c9f8a8ab6 100644 --- a/src/wallet/sqlite.cpp +++ b/src/wallet/sqlite.cpp @@ -282,7 +282,7 @@ void SQLiteDatabase::Open() // Now begin a transaction to acquire the exclusive lock. This lock won't be released until we close because of the exclusive locking mode. int ret = sqlite3_exec(m_db, "BEGIN EXCLUSIVE TRANSACTION", nullptr, nullptr, nullptr); if (ret != SQLITE_OK) { - throw std::runtime_error("SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of " PACKAGE_NAME "?\n"); + throw std::runtime_error("SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of " CLIENT_NAME "?\n"); } ret = sqlite3_exec(m_db, "COMMIT", nullptr, nullptr, nullptr); if (ret != SQLITE_OK) { diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp index 652d6e9f6d8..45b866d60df 100644 --- a/src/wallet/wallet.cpp +++ b/src/wallet/wallet.cpp @@ -2495,7 +2495,7 @@ bool CWallet::DelAddressBookWithDB(WalletBatch& batch, const CTxDestination& add // NOTE: This isn't a problem for sending addresses because they don't have any data that needs to be kept. // When adding new address data, it should be considered here whether to retain or delete it. if (IsMine(address)) { - WalletLogPrintf("%s called with IsMine address, NOT SUPPORTED. Please report this bug! %s\n", __func__, PACKAGE_BUGREPORT); + WalletLogPrintf("%s called with IsMine address, NOT SUPPORTED. Please report this bug! %s\n", __func__, CLIENT_BUGREPORT); return false; } // Delete data rows associated with this address @@ -3008,7 +3008,7 @@ std::shared_ptr CWallet::Create(WalletContext& context, const std::stri walletFile)); } else if (nLoadWalletRet == DBErrors::TOO_NEW) { - error = strprintf(_("Error loading %s: Wallet requires newer version of %s"), walletFile, PACKAGE_NAME); + error = strprintf(_("Error loading %s: Wallet requires newer version of %s"), walletFile, CLIENT_NAME); return nullptr; } else if (nLoadWalletRet == DBErrors::EXTERNAL_SIGNER_SUPPORT_REQUIRED) { @@ -3017,7 +3017,7 @@ std::shared_ptr CWallet::Create(WalletContext& context, const std::stri } else if (nLoadWalletRet == DBErrors::NEED_REWRITE) { - error = strprintf(_("Wallet needed to be rewritten: restart %s to complete"), PACKAGE_NAME); + error = strprintf(_("Wallet needed to be rewritten: restart %s to complete"), CLIENT_NAME); return nullptr; } else if (nLoadWalletRet == DBErrors::NEED_RESCAN) { warnings.push_back(strprintf(_("Error reading %s! Transaction data may be missing or incorrect." diff --git a/src/wallet/wallettool.cpp b/src/wallet/wallettool.cpp index b78985264ae..f7e7b74fc36 100644 --- a/src/wallet/wallettool.cpp +++ b/src/wallet/wallettool.cpp @@ -75,10 +75,10 @@ static std::shared_ptr MakeWallet(const std::string& name, const fs::pa name); } else if (load_wallet_ret == DBErrors::TOO_NEW) { tfm::format(std::cerr, "Error loading %s: Wallet requires newer version of %s", - name, PACKAGE_NAME); + name, CLIENT_NAME); return nullptr; } else if (load_wallet_ret == DBErrors::NEED_REWRITE) { - tfm::format(std::cerr, "Wallet needed to be rewritten: restart %s to complete", PACKAGE_NAME); + tfm::format(std::cerr, "Wallet needed to be rewritten: restart %s to complete", CLIENT_NAME); return nullptr; } else if (load_wallet_ret == DBErrors::NEED_RESCAN) { tfm::format(std::cerr, "Error reading %s! Some transaction data might be missing or" diff --git a/test/config.ini.in b/test/config.ini.in index 7e658d3a869..3bf79ef25d9 100644 --- a/test/config.ini.in +++ b/test/config.ini.in @@ -6,8 +6,8 @@ # test/*/test_runner.py and test/util/rpcauth-test.py [environment] -PACKAGE_NAME=@CLIENT_NAME@ -PACKAGE_BUGREPORT=@CLIENT_BUGREPORT@ +CLIENT_NAME=@CLIENT_NAME@ +CLIENT_BUGREPORT=@CLIENT_BUGREPORT@ SRCDIR=@abs_top_srcdir@ BUILDDIR=@abs_top_builddir@ EXEEXT=@EXEEXT@ diff --git a/test/functional/feature_addrman.py b/test/functional/feature_addrman.py index c4e60fba123..62f9cee1dfa 100755 --- a/test/functional/feature_addrman.py +++ b/test/functional/feature_addrman.py @@ -54,7 +54,7 @@ def run_test(self): peers_dat = os.path.join(self.nodes[0].chain_path, "peers.dat") init_error = lambda reason: ( f"Error: Invalid or corrupt peers.dat \\({reason}\\). If you believe this " - f"is a bug, please report it to {self.config['environment']['PACKAGE_BUGREPORT']}. " + f"is a bug, please report it to {self.config['environment']['CLIENT_BUGREPORT']}. " f'As a workaround, you can move the file \\("{re.escape(peers_dat)}"\\) out of the way \\(rename, ' "move, or delete\\) to have a new one created on the next start." ) diff --git a/test/functional/feature_filelock.py b/test/functional/feature_filelock.py index 79d2f65164b..f56643c62ec 100755 --- a/test/functional/feature_filelock.py +++ b/test/functional/feature_filelock.py @@ -30,7 +30,7 @@ def run_test(self): self.log.info(f"Using datadir {datadir}") self.log.info("Check that we can't start a second bitcoind instance using the same datadir") - expected_msg = f"Error: Cannot obtain a lock on data directory {datadir}. {self.config['environment']['PACKAGE_NAME']} is probably already running." + expected_msg = f"Error: Cannot obtain a lock on data directory {datadir}. {self.config['environment']['CLIENT_NAME']} is probably already running." self.nodes[1].assert_start_raises_init_error(extra_args=[f'-datadir={self.nodes[0].datadir_path}', '-noserver'], expected_msg=expected_msg) self.log.info("Check that cookie and PID file are not deleted when attempting to start a second bitcoind using the same datadir") @@ -46,7 +46,7 @@ def check_wallet_filelock(descriptors): wallet_dir = self.nodes[0].wallets_path self.log.info("Check that we can't start a second bitcoind instance using the same wallet") if descriptors: - expected_msg = f"Error: SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of {self.config['environment']['PACKAGE_NAME']}?" + expected_msg = f"Error: SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of {self.config['environment']['CLIENT_NAME']}?" else: expected_msg = "Error: Error initializing wallet database environment" self.nodes[1].assert_start_raises_init_error(extra_args=[f'-walletdir={wallet_dir}', f'-wallet={wallet_name}', '-noserver'], expected_msg=expected_msg, match=ErrorMatch.PARTIAL_REGEX) diff --git a/test/functional/feature_settings.py b/test/functional/feature_settings.py index a7294944bf5..e9148b79230 100755 --- a/test/functional/feature_settings.py +++ b/test/functional/feature_settings.py @@ -46,7 +46,7 @@ def run_test(self): # Assert default settings file was created self.stop_node(0) - default_settings = {"_warning_": f"This file is automatically generated and updated by {self.config['environment']['PACKAGE_NAME']}. Please do not edit this file while the node is running, as any changes might be ignored or overwritten."} + default_settings = {"_warning_": f"This file is automatically generated and updated by {self.config['environment']['CLIENT_NAME']}. Please do not edit this file while the node is running, as any changes might be ignored or overwritten."} with settings.open() as fp: assert_equal(json.load(fp), default_settings) diff --git a/test/functional/interface_bitcoin_cli.py b/test/functional/interface_bitcoin_cli.py index 7194c8ece41..3fe6570dd16 100755 --- a/test/functional/interface_bitcoin_cli.py +++ b/test/functional/interface_bitcoin_cli.py @@ -375,7 +375,7 @@ def run_test(self): self.log.info("Test -version with node stopped") self.stop_node(0) cli_response = self.nodes[0].cli('-version').send_cli() - assert f"{self.config['environment']['PACKAGE_NAME']} RPC client version" in cli_response + assert f"{self.config['environment']['CLIENT_NAME']} RPC client version" in cli_response self.log.info("Test -rpcwait option successfully waits for RPC connection") self.nodes[0].start() # start node without RPC connection diff --git a/test/functional/test_framework/test_framework.py b/test/functional/test_framework/test_framework.py index 49212eb0195..70ec8f09880 100755 --- a/test/functional/test_framework/test_framework.py +++ b/test/functional/test_framework/test_framework.py @@ -349,7 +349,7 @@ def shutdown(self): self.log.error("Hint: Call {} '{}' to consolidate all logs".format(os.path.normpath(os.path.dirname(os.path.realpath(__file__)) + "/../combine_logs.py"), self.options.tmpdir)) self.log.error("") self.log.error("If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.") - self.log.error(self.config['environment']['PACKAGE_BUGREPORT']) + self.log.error(self.config['environment']['CLIENT_BUGREPORT']) self.log.error("") exit_code = TEST_EXIT_FAILED # Logging.shutdown will not remove stream- and filehandlers, so we must diff --git a/test/functional/tool_wallet.py b/test/functional/tool_wallet.py index 784a7698829..86292c0f0b1 100755 --- a/test/functional/tool_wallet.py +++ b/test/functional/tool_wallet.py @@ -203,7 +203,7 @@ def test_invalid_tool_commands_and_args(self): locked_dir = self.nodes[0].wallets_path error = 'Error initializing wallet database environment "{}"!'.format(locked_dir) if self.options.descriptors: - error = f"SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of {self.config['environment']['PACKAGE_NAME']}?" + error = f"SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of {self.config['environment']['CLIENT_NAME']}?" self.assert_raises_tool_error( error, '-wallet=' + self.default_wallet_name, diff --git a/test/functional/wallet_multiwallet.py b/test/functional/wallet_multiwallet.py index 149b1246d84..9a339088fc3 100755 --- a/test/functional/wallet_multiwallet.py +++ b/test/functional/wallet_multiwallet.py @@ -204,7 +204,7 @@ def wallet_file(name): self.restart_node(0, ['-nowallet', '-walletdir=' + competing_wallet_dir]) self.nodes[0].createwallet(self.default_wallet_name) if self.options.descriptors: - exp_stderr = f"Error: SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of {self.config['environment']['PACKAGE_NAME']}?" + exp_stderr = f"Error: SQLiteDatabase: Unable to obtain an exclusive lock on the database, is it being used by another instance of {self.config['environment']['CLIENT_NAME']}?" else: exp_stderr = r"Error: Error initializing wallet database environment \"\S+competing_walletdir\S*\"!" self.nodes[1].assert_start_raises_init_error(['-walletdir=' + competing_wallet_dir], exp_stderr, match=ErrorMatch.PARTIAL_REGEX)