Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize NFT contract code #22

Open
5 tasks
whoabuddy opened this issue Nov 21, 2022 · 0 comments
Open
5 tasks

Optimize NFT contract code #22

whoabuddy opened this issue Nov 21, 2022 · 0 comments

Comments

@whoabuddy
Copy link
Contributor

whoabuddy commented Nov 21, 2022

Looking over the default template, there are a few things:

  • remove MAX-SUPPLY and references
  • WALLET can be removed in favor of BTC receiver address (Add swap parameters to NFT contract #21)
  • ERR-SOLD-OUT may not be necessary
  • claim should be renamed to eliminate confusion on what it does for the person running it (maybe create or process)
  • mint-many should be converted into a single mint function instead of iterating over a list

Thinking some more on this - maybe claim and mint should be combined into one public function? It would accept the BTC TX, and as long as it's valid per the requirements, complete the mint. Will definitely tie into #18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant