[BUG] - ARC Broadcast should return status error when a double spend is detected.

[BraydenLangley]

Bug Description

As described in this PR by @sirdeggen, "orphan should not be considered success. So we ought to go back and make sure the ARC client is making good decisions about whether or not a tx is considered successfully broadcast."

Steps to Reproduce

1. Create a new transaction that consumes an already spent output.
2. Broadcast the transaction to ARC.
3. The status returned, last tested, says "success" instead of "error".

Expected Behavior

In order to correctly identify broadcast errors using the isBroadcastFailure function, the ARC broadcaster should correctly return errors with status of "error" for all common errors that need to be handled.

[boecklim]

Hello @BraydenLangley
Here is an example of the response of a tx submission of a tx to ARC with a double spent input

{
    "blockHash": "",
    "blockHeight": 0,
    "competingTxs": [
        "5e58f06a8334301ff77d9109aab08dcc38d89e8cc7bd55da16affa948281d7ed"
    ],
    "extraInfo": "",
    "merklePath": "",
    "status": 200,
    "timestamp": "2024-11-04T09:29:36.89060411Z",
    "title": "OK",
    "txStatus": "DOUBLE_SPEND_ATTEMPTED",
    "txid": "89100426fc13a55260fa65e621e7591f8b01007af62480e818d0da518723bfd3"
}

When you say

The status returned, last tested, says "success" instead of "error".

Which field do you refer to?
Or is it the http status 200 which you mean?