Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to rust-bitcoin 0.31.0 #1196

Closed
tnull opened this issue Nov 7, 2023 · 5 comments · Fixed by #1177
Closed

Upgrade to rust-bitcoin 0.31.0 #1196

tnull opened this issue Nov 7, 2023 · 5 comments · Fixed by #1177
Labels
api A breaking API change module-blockchain module-wallet new feature New feature or request
Milestone
1.0.0-alpha

Comments

@tnull
Copy link
Contributor

tnull commented Nov 7, 2023

Describe the enhancement
rust-bitcoin 0.31.0 was recently released and includes changes that so far kept LDK from upgrading to 0.3X.Y (cf. lightningdevkit/rust-lightning#2124 (comment)).

Additional context
Probably currently blocked on rust-bitcoin/rust-miniscript#622
@tnull tnull added the new feature New feature or request label Nov 7, 2023
@nondiremanuel nondiremanuel added this to BDK Nov 7, 2023
@nondiremanuel nondiremanuel moved this to Todo in BDK Nov 7, 2023
@nondiremanuel nondiremanuel added this to the 1.0.0-alpha.3 milestone Nov 7, 2023
@notmandatory notmandatory modified the milestones: 1.0.0-alpha.3, 1.0.0-alpha.4 Nov 13, 2023
@nondiremanuel nondiremanuel mentioned this issue Nov 19, 2023
Closed
54 tasks
@tnull
Copy link
Contributor Author

tnull commented Nov 23, 2023

This now seems unblocked as rust-miniscript 11.0 was just released.

@tnull tnull mentioned this issue Nov 23, 2023
Closed
@nondiremanuel nondiremanuel mentioned this issue Dec 2, 2023
Closed
55 tasks
@tnull
Copy link
Contributor Author

tnull commented Dec 12, 2023

@notmandatory Is the current plan to do this as part of 1.0-alpha.3 or 1.0-alpha.4? Trying to wrap my head around when I need for LDK to upgrade to be able to use the latest bdk/rust-esplora-client/rust-electrum-client in LDK Node.

@notmandatory
Copy link
Member

notmandatory commented Dec 13, 2023 •
edited
Loading

@tnull this PR is still scheduled for the bdk 1.0-alpha.X milestone release. But you are correct we also need to make sure the below PRs are released first:

  1. Upgrade bitcoin to v0.31 rust-electrum-client#121 released in 0.19.0
  2. Upgrade bitcoin RCasatta/electrsd#74 released in 0.27.0
  3. Upgrade bitcoin to v0.31 rust-esplora-client#79 released in 0.7.0
  4. Upgrade bitcoin rust-hwi#91 released in 0.8.0

@notmandatory notmandatory mentioned this issue Dec 13, 2023
Merged
@nondiremanuel nondiremanuel modified the milestones: 1.0.0-alpha.4, 1.0.0 Jan 6, 2024
@nondiremanuel
Copy link

nondiremanuel commented Jan 25, 2024 •
edited
Loading

Needs to stay in 1.0.0 milestone in order to not block LDK, but we need to check also other dependencies
It makes sense to upgrade to rust 0.31.0 for beta (It doesn't seem 0.31 changes are too drastic)

@nondiremanuel nondiremanuel added the api A breaking API change label Jan 25, 2024
@notmandatory
Copy link
Member

take a look at #1191 when this one is done.

@notmandatory notmandatory mentioned this issue Mar 21, 2024
Closed
@notmandatory notmandatory moved this from Todo to In Progress in BDK Mar 30, 2024
@notmandatory notmandatory moved this from In Progress to Needs Review in BDK Apr 12, 2024
@github-project-automation github-project-automation bot moved this from Needs Review to Done in BDK Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api A breaking API change module-blockchain module-wallet new feature New feature or request
Projects
BDK
Archived in project
Milestone
1.0.0-alpha
Development

Successfully merging a pull request may close this issue.

Upgrade bitcoin/miniscript dependencies tcharding/bdk
3 participants
@tnull @notmandatory @nondiremanuel