Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: pin deps for MSRV #1674

Merged
merged 1 commit into from
Nov 5, 2024
Merged

ci: pin deps for MSRV #1674

merged 1 commit into from
Nov 5, 2024

Conversation

ValuedMammal
Copy link
Contributor

@ValuedMammal ValuedMammal commented Nov 5, 2024 •
edited
Loading

Pin deps in CI to build on MSRV

  • pin indexmap to 2.5.0
  • pin security-framework-sys to 2.11.1

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@ValuedMammal
ci: pin deps for MSRV
d277150 
- pin `indexmap` to 2.5.0
- pin `security-framework-sys` to 2.11.1
notmandatory
notmandatory approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d277150

@notmandatory notmandatory added the ci label Nov 5, 2024
@notmandatory notmandatory added this to the 1.0.0-beta milestone Nov 5, 2024
@ValuedMammal ValuedMammal merged commit 60214fb into bitcoindevkit:master Nov 5, 2024
21 checks passed
@ValuedMammal ValuedMammal deleted the ci/msrv branch November 5, 2024 18:28
@notmandatory notmandatory mentioned this pull request Dec 12, 2024
Closed
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees

@ValuedMammal ValuedMammal

Labels
ci
Projects
BDK
Archived in project
Milestone
1.0.0-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@ValuedMammal @notmandatory