Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transaction builder page #79

Merged

Conversation

thunderbiscuit
Copy link
Member

This PR adds the page that deals with the transaction builder.

I'm not sure yet how/if it makes sense to have a runnable example for this but I needed to see the codeblocks first.

Copy link
Contributor

@riverKanies riverKanies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

catching errors like this is the main benefit of using code snippets IMO


```rust
wallet.build_tx()
.fee_rate(FeeRate::from_sat_per_vb(2.0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to edit to get working:

    let mut tx_builder = wallet.build_tx();
    tx_builder.fee_rate(FeeRate::from_sat_per_vb(4).unwrap());
    ```

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks yep! We switched FeeRate types a few versions ago and it went from a float to a u64 I think. Perfect!

@thunderbiscuit thunderbiscuit merged commit 3bb066a into bitcoindevkit:master Nov 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants