From 1f1072586fd479e44827c062c7e3d5f5e5632e30 Mon Sep 17 00:00:00 2001 From: Sabine Holler Date: Wed, 17 Jan 2024 14:45:38 +0100 Subject: [PATCH] Review feedbacks, changelog texts --- CHANGELOG.md | 4 ++-- scss/bitstyles/organisms/page-header/PageHeader.js | 11 ++++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 829efdc3d..3b5e8d954 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,9 +8,9 @@ ### Added -- Page Header Organism, added a page header organism component and storybook docs for it. +- New Pageheader Organism-level component, that encapsulates what was previously an example component built using utility classes. -- Sidebar component updates +- Updates the layout of the Sidebar Organism-level component, improvements to the scrolling behavior and uses the invisible button variant. - Badge with Label, added an example showing a text label rendered next to a badge component, to the badge docs. - A new layout component at `atoms/switcher`, that lays out its children in a horizontal row with consistent spacing between children. The layout switches to a vertical stack once the width of the component passes below a threshold, or the number of children goes over a limit. diff --git a/scss/bitstyles/organisms/page-header/PageHeader.js b/scss/bitstyles/organisms/page-header/PageHeader.js index b495500f4..4dc7380ba 100644 --- a/scss/bitstyles/organisms/page-header/PageHeader.js +++ b/scss/bitstyles/organisms/page-header/PageHeader.js @@ -91,13 +91,14 @@ breadCrumbsMenu.innerHTML = ` `; -export const header = document.createElement('div'); +export const header = document.createElement('header'); header.innerHTML = `
-
-

Title Header

-
- Online +
+

Title Header

+
+ Online +
`;