Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update icons #786

Open
planktonic opened this issue May 24, 2023 · 0 comments
Open

Update icons #786

planktonic opened this issue May 24, 2023 · 0 comments
Assignees

Comments

@planktonic
Copy link
Member

planktonic commented May 24, 2023

  • When the new icon set is finalised, we should update the Icon component used here in our docs. The new icons should either be provided here, or imported from an external package.
  • Icons used in XSmall Square & Round buttons should be the 20dp icons.
  • Tab button, Icon only has 16px padding, should be 12px. Can we do that somehow, avoiding making button styles dependent on content, and without introducing a new button type. Perhaps just the square & round buttons could have their padding set to zero, so the min-height and min-width properties can be solely responsible for the button size
  • Update badge-button icons to use "X" icon in examples
  • atoms/flash: use Outline icons not filled
  • our buttons currently output icons with a-icon--m. Let’s switch to not outputting a size unless needed (e.g. perhaps small buttons should get small icons)
@planktonic planktonic self-assigned this May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant