Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use focus design token on radios, checkboxes, selects #827

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

angelikatyborska
Copy link
Contributor

@angelikatyborska angelikatyborska commented Aug 19, 2024

Fixes #820

Changes

  • selects, radio inputs, and checkboxes now use design-tokens/focus for focus-visible styles

📸 Looks like

Providing gifs because the style changes include a transition.

Select

2024-08-19 10 27 06

Radio

2024-08-19 10 27 22

Checkbox

2024-08-19 10 27 36

How to QA

👀 Visual changes

Insert a detailed list explaining exactly how to QA your changes from a designer’s PoV

  • git fetch
  • git checkout <pr-branch-name>
  • yarn
  • yarn storybook
  • navigate to Base / Checkbox, Base / Radio, and Base / Select

Check:

  • The appearance matches the design in Zeplin
  • The Zeplin component is correctly linked in storybook
  • The documentation for this component is correct, understandable, and up-to-date.

👾 Code changes

Check:

  • The documentation for this component is correct, understandable, and up-to-date.
  • The component makes good use of CSS custom properties to simplify creating variants (or doesn’t have variants).
  • Everything that should be a variable, is.

Preflight checks

PR author to check, and delete if not applicable

  • Storybook documentation has been updated
  • Fixtures in test/scss/ have been updated
  • Your changes have been added to the unreleased section of CHANGELOG.md

@angelikatyborska angelikatyborska marked this pull request as ready for review August 19, 2024 08:33
@angelikatyborska
Copy link
Contributor Author

See comments in #820 (comment) before reviewing

@angelikatyborska
Copy link
Contributor Author

angelikatyborska commented Aug 27, 2024

Note to self: what about dialogs? dialogs are focusable

Another note to self: scrollable elements can be focused in Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focus-visible styles for inputs
1 participant