Extract sync framework interaction to separate class #1137
+161
−88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
Purpose
This is part of moving further away from the Sync Adapter Framework, which has been mostly replaced by Work Manager and is only used for sync requests coming from 3rd party apps and content changes.
While
SyncAdapterServices
is the entry point for said sync requests we are still en-/disabling general sync-ability and content triggered syncs via the sync framework APIContentResolver
. These calls should be made from a single central place.If we would ever like to change the notification of changed content provider entries to JobScheduler / WorkManager (https://github.com/bitfireAT/davx5/issues/247), it will be possible by adapting mainly this class and
SyncAdapterServices
.Short description
SyncFrameworkIntegration
class with all necessary methods.ContentResolver
calls are made, except for in the migrationsNote that due to the Android 7 upload work-around there are still several where
ContentResolver.SYNC_EXTRAS_UPLOAD
is in use.Checklist