Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POST /api/crypto/addresses : only one network is returned #119

Open
richard5334 opened this issue Jul 3, 2023 · 0 comments
Open

POST /api/crypto/addresses : only one network is returned #119

richard5334 opened this issue Jul 3, 2023 · 0 comments

Comments

@richard5334
Copy link

Dear Bitkub,

I think it would be nice to provide to provide all addresses for all network. There are some coins (like USDT) that you support 2 networks. However, the API only returns one address + one network.

Because you return it as a list, it's fairly easy to simply add the entry as follow:

  {"currency": "USDT",
   "address": "0xc0ffee254729296a45a3885639AC7E10F9d54979",
   "tag": "",
   "network": "ETH",
   "time": 1676396568},
  {"currency": "USDT",
   "address": "0xc0ffee254729296a45a3885639AC7E10F9d54979",
   "tag": "",
   "network": "BSC",
   "time": 1676396568},

It will remain fairly easy to parse.

An alternative (or even better), is to add the endpoint /api/crypto/address with body:{"cur": "USDC", "net": "BSC"}
Where it would return

{
   "currency": "USDC",
   "address": "0xc0ffee254729296a45a3885639AC7E10F9d54979",
   "tag": "",
   "network": "BSC",
   "time": 1676396568
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant