Update storage pumper redis usage watermark #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #216 +/- ##
==========================================
- Coverage 56.11% 56.05% -0.07%
==========================================
Files 38 38
Lines 2983 2983
==========================================
- Hits 1674 1672 -2
- Misses 1092 1093 +1
- Partials 217 218 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
git-hulk
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When storage pumper pumps ready job from database to redis, it will check the current redis usage.
If the usage is above the threshold(previously set to 60%), the pumper will stop pumping jobs to redis.
This PR adjust that threshold from 60% to 80% based on real-life scenario, for 80% can be regarded as a relatively safe base line.