Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seed phrase BIP32 only allows us 128-256 bits #70

Open
jaytaph opened this issue Nov 16, 2020 · 4 comments
Open

seed phrase BIP32 only allows us 128-256 bits #70

jaytaph opened this issue Nov 16, 2020 · 4 comments
Labels
needs discussion Things are not clear yet and needs discussion on how to solve/implement

Comments

@jaytaph
Copy link
Member

jaytaph commented Nov 16, 2020

Since we will have an irregular number of bits, we need to find a way to achieve this.

@jaytaph
Copy link
Member Author

jaytaph commented Nov 17, 2020

This has an issue..

BIP32 is used for random data, meaning the words will be randomly chosen. However, since we use semi-deterministic data (mostly 0, 1 etc), the words will be the same over and over again.

We could find a way to fix this (maybe xor with the random data, so we get random data, yet still able to extract our types)

@acalatrava
Copy link
Contributor

isn't this already "fixed" by using AES as we thought about? https://github.com/bitmaelum/bitmaelum-suite/wiki/Account-(re)generation-and-mnemonic-seed

@jaytaph
Copy link
Member Author

jaytaph commented Nov 17, 2020

indeed.. i forgot already :p

@jaytaph jaytaph added the needs discussion Things are not clear yet and needs discussion on how to solve/implement label Jan 21, 2021
@jaytaph
Copy link
Member Author

jaytaph commented Jan 27, 2021

This is implementation specific. For now we agree to use per-key seeds, which means we do not need a large seed string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs discussion Things are not clear yet and needs discussion on how to solve/implement
Projects
None yet
Development

No branches or pull requests

2 participants